Skip to content

test(miner): rename gittensory-miner/ams prose to loopover-miner/ams (batch 3) - #5888

Merged
JSONbored merged 1 commit into
mainfrom
rebrand/test-prose-miner-ams-3
Jul 14, 2026
Merged

test(miner): rename gittensory-miner/ams prose to loopover-miner/ams (batch 3)#5888
JSONbored merged 1 commit into
mainfrom
rebrand/test-prose-miner-ams-3

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • Part of the gittensory→loopover rebrand (Epic: complete the gittensory -> loopover rebrand (full cutover, no dual-support) #5705), phase 8b: rename remaining test-title prose. This final batch covers 26 test/unit/*.ts files (plan-store, policy caches, portfolio-queue, prediction-ledger, replay, repo-clone, worktree-allocator, and the opportunity-fanout/selfhost-ams clusters) whose describe()/it() titles and mkdtempSync/tempRoot tmpdir prefixes still used the bare gittensory-miner/gittensory-ams strings.
  • Also fixes real stale strings this sweep surfaced in packages/loopover-miner/lib/status.js: a monorepo-workspace-fallback path (readInstalledEnginePackageVersion/readExpectedEnginePackageVersion) that pointed at ../../gittensory-engine/package.json — a directory that no longer exists (the real package is packages/loopover-engine), so this fallback silently returned null instead of the real version when node_modules resolution fails in monorepo dev mode — plus a stale "no .gittensory-miner config found" doctor-check message and an unused write-probe filename. Test assertion updated in the same commit.
  • No other functional/runtime identifier changes — purely test-label and comment prose, plus the status.js fixes above.

Scope

  • The PR title follows type(scope): short summary Conventional Commit format.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves — N/A, maintainer-authored rebrand-epic cleanup (Epic: complete the gittensory -> loopover rebrand (full cutover, no dual-support) #5705), no linked-issue gate applies to owner PRs.

Validation

  • git diff --check
  • npm run actionlint (via npm run test:ci)
  • npm run typecheck (via npm run test:ci)
  • npm run test:coverage — full unsharded run, 100% green
  • npm run test:workers (via npm run test:ci)
  • npm run build:mcp (via npm run test:ci)
  • npm run test:mcp-pack (via npm run test:ci)
  • npm run ui:openapi:check (via npm run test:ci)
  • npm run ui:lint (via npm run test:ci)
  • npm run ui:typecheck (via npm run test:ci)
  • npm run ui:build (via npm run test:ci)
  • npm audit --audit-level=moderate
  • Full npm run test:ci gate run locally, exit 0

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. — N/A, no such changes.
  • API/OpenAPI/MCP behavior is updated and tested where needed. — N/A, no behavior change.
  • UI changes use live API data or real empty/error/loading states. — N/A, no UI changes.
  • Visible UI changes include a UI Evidence section. — N/A, no UI changes.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs (none touched here).

Notes

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored self-assigned this Jul 14, 2026
@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 14, 2026
@loopover-orb

loopover-orb Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 LoopOver review result - fixes required

Review updated: 2026-07-14 21:41:48 UTC

27 files · 1 AI reviewer · 1 blocker · readiness 80/100 · CI failing · blocked

🛑 Suggested Action - Manual Review

Review summary
This is a mechanical test-prose rename sweep (gittensory-miner/ams → loopover-miner/ams) across 26 test files, updating describe/it titles and mkdtempSync/tempRoot tmpdir prefixes, paired with a real fix in packages/loopover-miner/lib/status.js where the monorepo-workspace-fallback path pointed at a nonexistent ../../gittensory-engine/package.json directory instead of the actual packages/loopover-engine. The status.js changes are traceable and correct (readInstalledEnginePackageVersion, readExpectedEnginePackageVersion, checkConfigContent's stale doctor message, and the write-probe filename all now consistently use loopover- prefixes), and the corresponding test assertions in miner-status.test.ts were updated in the same commit to match. Everything else in the diff is a pure string rename with no logic changes, and the tmpdir-prefix renames carry no behavioral risk since mkdtempSync appends a random suffix regardless of prefix.

Nits — 5 non-blocking
  • test/unit/miner-rejection-state-machine.test.ts:6 and miner-rejection-templates.test.ts:6 still hardcode repoFullName: "JSONbored/gittensory" in their CONTEXT fixtures — out of this PR's stated scope (titles/tmpdir prefixes only) but worth a follow-up sweep so stale fixture data doesn't linger past the rebrand.
  • packages/loopover-miner/lib/status.js:120-124 duplicates the join(moduleDir(), "../../loopover-engine/package.json") computation in both the try and catch arms — could hoist to a single const above the try, purely stylistic.
  • Consider hoisting the repeated join(moduleDir(), "../../loopover-engine/package.json") in status.js's readInstalledEnginePackageVersion into one variable shared by both the try and catch branches.
  • Sweep the remaining 'JSONbored/gittensory' fixture strings in the rejection-state-machine/templates tests in a later rebrand batch for full consistency.
  • Pull request duplicates other open work — Check for an existing pull request or issue covering this change and coordinate or consolidate before continuing.

Why this is blocked

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
📋 Copy for AI agents — paste into your coding agent
Fix the following blocker(s) from this PR review:

1. No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

CI checks failing

  • validate
  • validate-tests (6)
  • validate-tests (5)
Signal Result Evidence
Code review ❌ 1 blocker 1 reviewer
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ⚠️ 1 scoped overlap Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 43 registered-repo PR(s), 35 merged, 385 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 43 PR(s), 385 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Improvement ✅ Minor risk: low · value: minor — Code changes are accompanied by test evidence.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: Python, TypeScript, Ruby, Go, JavaScript, MDX, Shell, Solidity
  • Official Gittensor activity: 43 PR(s), 385 issue(s).
  • Related work: Titles/paths share 9 meaningful terms. (PR #5886)
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Review top overlaps.
  • Add a concise scope and risk note.
  • No action.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

…(batch 3)

Rebrand cutover cleanup: update describe()/it() titles, mkdtempSync
tmpdir prefixes, and comments across 26 test/unit files (plan-store,
policy caches, portfolio-queue, prediction-ledger, replay, repo-clone,
worktree-allocator, and opportunity-fanout/selfhost-ams clusters) to
use the current loopover-miner/loopover-ams naming. Also fixes several
stale "gittensory" strings in packages/loopover-miner/lib/status.js
this sweep surfaced: a monorepo-fallback path that pointed at a
nonexistent "gittensory-engine" sibling directory (silently degrading
the engine-version doctor check to null in monorepo dev mode), and a
stale "no .gittensory-miner config found" detail message.
@JSONbored
JSONbored force-pushed the rebrand/test-prose-miner-ams-3 branch from 4ca8ca9 to 05210e7 Compare July 14, 2026 21:59
@JSONbored
JSONbored merged commit 5b0c9dc into main Jul 14, 2026
15 checks passed
@JSONbored
JSONbored deleted the rebrand/test-prose-miner-ams-3 branch July 14, 2026 22:05
JSONbored added a commit that referenced this pull request Jul 14, 2026
#5899)

Rebrand cutover cleanup: update brand-name prose in comments across
23 packages/loopover-miner/**/*.js(.d.ts) and packages/loopover-mcp
files. Includes a few real (non-comment) values with no external
consumer besides this repo's own code: the loopover-miner-mcp.js MCP
server's self-reported name, the cross-repo-evaluation failure-
category value, and status.js's monorepo-fallback path (which
pointed at a nonexistent "gittensory-engine" sibling directory).

If this lands before (or after) #5888, packages/loopover-miner/lib/
status.js's identical fix there will show as a no-op on rebase --
same underlying text, no conflict.
This was referenced Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant