test(miner): rename gittensory-miner/ams prose to loopover-miner/ams (batch 3) - #5888
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-14 21:41:48 UTC
🛑 Suggested Action - Manual Review Review summary Nits — 5 non-blocking
Why this is blocked
📋 Copy for AI agents — paste into your coding agentCI checks failing
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
…(batch 3) Rebrand cutover cleanup: update describe()/it() titles, mkdtempSync tmpdir prefixes, and comments across 26 test/unit files (plan-store, policy caches, portfolio-queue, prediction-ledger, replay, repo-clone, worktree-allocator, and opportunity-fanout/selfhost-ams clusters) to use the current loopover-miner/loopover-ams naming. Also fixes several stale "gittensory" strings in packages/loopover-miner/lib/status.js this sweep surfaced: a monorepo-fallback path that pointed at a nonexistent "gittensory-engine" sibling directory (silently degrading the engine-version doctor check to null in monorepo dev mode), and a stale "no .gittensory-miner config found" detail message.
4ca8ca9 to
05210e7
Compare
#5899) Rebrand cutover cleanup: update brand-name prose in comments across 23 packages/loopover-miner/**/*.js(.d.ts) and packages/loopover-mcp files. Includes a few real (non-comment) values with no external consumer besides this repo's own code: the loopover-miner-mcp.js MCP server's self-reported name, the cross-repo-evaluation failure- category value, and status.js's monorepo-fallback path (which pointed at a nonexistent "gittensory-engine" sibling directory). If this lands before (or after) #5888, packages/loopover-miner/lib/ status.js's identical fix there will show as a no-op on rebase -- same underlying text, no conflict.
Summary
test/unit/*.tsfiles (plan-store, policy caches, portfolio-queue, prediction-ledger, replay, repo-clone, worktree-allocator, and the opportunity-fanout/selfhost-ams clusters) whosedescribe()/it()titles andmkdtempSync/tempRoottmpdir prefixes still used the baregittensory-miner/gittensory-amsstrings.packages/loopover-miner/lib/status.js: a monorepo-workspace-fallback path (readInstalledEnginePackageVersion/readExpectedEnginePackageVersion) that pointed at../../gittensory-engine/package.json— a directory that no longer exists (the real package ispackages/loopover-engine), so this fallback silently returnednullinstead of the real version when node_modules resolution fails in monorepo dev mode — plus a stale"no .gittensory-miner config found"doctor-check message and an unused write-probe filename. Test assertion updated in the same commit.Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlint(vianpm run test:ci)npm run typecheck(vianpm run test:ci)npm run test:coverage— full unsharded run, 100% greennpm run test:workers(vianpm run test:ci)npm run build:mcp(vianpm run test:ci)npm run test:mcp-pack(vianpm run test:ci)npm run ui:openapi:check(vianpm run test:ci)npm run ui:lint(vianpm run test:ci)npm run ui:typecheck(vianpm run test:ci)npm run ui:build(vianpm run test:ci)npm audit --audit-level=moderatenpm run test:cigate run locally, exit 0Safety
UI Evidencesection. — N/A, no UI changes.Notes
describe()/tmpdir-prefix renames tracked in rebrand epic Epic: complete the gittensory -> loopover rebrand (full cutover, no dual-support) #5705 (item 1 of 2). Follows test(miner): rename gittensory-miner/ams prose to loopover-miner/ams #5874, test(miner): rename gittensory-miner/ams prose to loopover-miner/ams (batch 2) #5878.