fix(ci): sync miner engine-version pin on the engine release branch - #5856
Conversation
scripts/check-engine-parity.ts requires packages/loopover-miner/expected-engine.version to match packages/loopover-engine/package.json's version, but release-please's engine component only ever touches files under packages/loopover-engine/**, so it can never update that cross-package pin itself. This left every engine release PR structurally unable to pass CI (confirmed on the engine-v3.1.0 release PR, #5807). Extends the existing package-lock.json sync step to also write the pin whenever the engine branch's version changes.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5856 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 587 587
Lines 46509 46509
Branches 14870 14870
=======================================
Hits 44238 44238
Misses 1515 1515
Partials 756 756
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-14 20:07:23 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Concerns raised — review before merging
📋 Copy for AI agents — paste into your coding agent
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
test:engine-parityevery time, becausescripts/check-engine-parity.ts'scheckMinerEngineVersionPinSyncrequirespackages/loopover-miner/expected-engine.versionto matchpackages/loopover-engine/package.json's version, but release-please'senginecomponent only ever touches files underpackages/loopover-engine/**— it has no way to update that cross-package pin.mcp-release-please.ymlto also write the pin file whenever the engine branch's version changes, reusing the same fetch/checkout/commit-if-changed pattern already used for the lockfile.Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typecheck— skipped, no.ts/source files touched (workflow-YAML-only change).npm run test:coverage— skipped,src/**untouched, not covered by Codecov patch, no new branches introduced.npm run test:workers/npm run build:mcp/npm run test:mcp-pack/npm run ui:*— skipped, none of these are affected by a.github/workflows/**-only change.npm audit --audit-level=moderate— skipped, no dependency changes.node -p/printf/git diff --quietlogic locally against a scratch git repo before pushing.If any required check was skipped, explain why:
.github/workflows/**-only change (nosrc/,test/, or dependency changes), so the JS/TS build, typecheck, coverage, and UI checks have no surface to exercise.actionlint(the workflow-syntax validator) passed, and the new bash block's version-read/write/diff logic was manually dry-run locally.Safety
UI Evidencesection. — N/A, no UI changes.CHANGELOG.md.Notes
enginerelease-please PR (chore(release): cut engine v3.1.0 #5807) had cascadingvalidate-testsfailures despite a clean merge state.