Skip to content

refactor(engine): extract signals engine with re-export shim (#4884) #5800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 14, 2026
Merged

refactor(engine): extract signals engine with re-export shim (#4884) #5800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions packages/loopover-engine/src/reward-risk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@
// gittensory-miner can rank candidate work locally with the same logic the maintainer-side gate computes.
//
// Unlike the earlier self-contained extractions, reward-risk sits on top of the maintainer signal stack in
// `src/signals/engine.ts` (`buildRoleContext`, `buildLaneAdvice`, `buildCollisionReport`, `buildQueueHealth`,
// `buildRepoFitRecommendation`, `buildContributorIntakeHealth`, `buildPullRequestReviewIntelligence`) from
// `src/signals/engine.ts`. Those builders are not yet extracted (and are far too large to port under the
// per-issue size cap), so — rather than reach back into `src/`, which this package must never do — they are
// DEPENDENCY-INJECTED via `RewardRiskEngineDeps`. `isFailingCheckSummary` now lives in
// `./signals/check-summary.js` (#4256). The `src/signals/reward-risk.ts` shim binds the real `src` builders;
// a follow-up issue can drop the injection once they have engine homes.
// `packages/loopover-engine/src/signals/engine.ts` (#4884; monorepo shim at `src/signals/engine.ts`).
// Those builders still arrive via injected `RewardRiskEngineDeps` — `src/signals/reward-risk.ts` binds the
// real engine implementations. `isFailingCheckSummary` is imported directly from `./signals/check-summary.js`
// (#4256).
import type { ScorePreviewResult } from "./scoring/preview.js";
import { buildScorePreview } from "./scoring/preview.js";
import { isFailingCheckSummary } from "./signals/check-summary.js";
Expand Down Expand Up @@ -61,8 +58,8 @@ export type PullRequestReviewabilityInput = {
};

/**
* The `src/signals/engine.ts` builders reward-risk depends on, injected so this package stays free of any
* `src/` import. The real `src`-typed builders bind cleanly: their argument records are wider than (assignable
* The `packages/loopover-engine/src/signals/engine.ts` builders reward-risk depends on, injected so this
* package stays free of any direct import of the host-only modules those builders still reach into (#4884). their argument records are wider than (assignable
* from) these engine mirrors, and their richer return types are covariantly assignable to the narrowed views
* above. `isFailingCheckSummary` is imported directly from `./signals/check-summary.js` (#4256).
*/
Expand Down
Loading