feat(review): synthesize the 'Contributor next steps' collapsible into a prioritized step - #5791
Conversation
…o a prioritized step The collapsible re-listed the same action text already shown verbatim in the Signals table's Action column, so it added nothing a reader hadn't already seen (JSONbored#5097). Redesign it to lead with the single highest-priority step as a 'Start here' synthesis — the one thing the flat table does not say — and point back to the table for the remainder, so no underlying signal is lost (publicSafeNextSteps still computes the full maintainer-lane note + readiness actions + finding actions, rendered in full in the table above). Both render sites (the converged comment and the legacy panel) route through the shared contributorNextStepsBody so they can never diverge. Closes JSONbored#5097
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5791 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 580 580
Lines 46152 46156 +4
Branches 14800 14803 +3
=======================================
+ Hits 43880 43884 +4
Misses 1516 1516
Partials 756 756
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-14 16:06:12 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 3 non-blocking
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
The "Contributor next steps" collapsible re-listed the exact same
actiontext already shown verbatim in the Signals table's own Action column, so it added nothing a careful reader hadn't already seen — which is why it read as low-value (#5097). This redesigns it (option b from the issue) to earn its place: it leads with the single highest-priority step as a "Start here" synthesis — the one thing the flat table does not say — and points back to the table for the remainder, so no underlying signal is lost.Written comparison (cut vs. redesign)
I chose (b) because the issue's expected outcome is "either it's gone, or it earns its place by saying something the table doesn't already say," and a prioritized "Start here" is genuinely new information (the flat table gives no ordering).
publicSafeNextStepsis unchanged, so the maintainer-lane note + readiness actions + finding actions are all still computed and still rendered in full in the table above.Example output for representative PR states
Clean PR (no actions) — unchanged fallback:
PR with 2 blockers (e.g. missing linked issue + a failing check):
Maintainer-lane PR (lead is the maintainer-lane context line, remaining actions pointed to the table):
No dependency lost
buildPublicSafeCollapsibles) and the legacy panel (buildPublicPrIntelligenceComment) — now route through the sharedcontributorNextStepsBody, so they can never diverge (the parity test asserts this).publicSafeNextSteps(the underlying signal) is untouched; nothing downstream reads the collapsible's rendered body as a data source (it's a display-only string), and there is no OpenAPI schema for the collapsible body.Scope
CONTRIBUTING.md; nosite//CNAME/lovable.Validation
git diff --checknpm run typecheck(root +@loopover/enginebuild) cleannpm run test:coverage— every changed line ofcontributorNextStepsBody(empty / single / multi-step, singular vs plural, dedup) is at 100% line + branch coverage; 5 new deterministic assertions inunified-comment-parity.test.tslock in the "Start here" format, and the existing converged-vs-legacy parity test still passes (both sites single-sourced).signals-coverage,scenario-summary,github-commands,mcp-release-candidate— 141 tests).scripts/check-engine-parity.tspasses (contributorNextStepsBodyis not a parity marker); docs-drift +command-reference:checkpass.mainimmediately before pushing — no base conflict.If any required check was skipped, explain why:
actionlint,test:workers,ui:*,npm auditwere not run — no workflow, worker, UI, or dependency surface changed. The fullnpm run test:ciruns them on CI.Safety
containsPrivatePublicTerm,publicSafePreflightFindings) is unchanged; this only reshapes already-public-safe strings.Auth/CORS/session, API/OpenAPI/MCP, and UI safety boxes are not applicable.