Skip to content

feat(api): add post-merge incident reporting for already-merged PRs #5766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 14, 2026
Merged

feat(api): add post-merge incident reporting for already-merged PRs #5766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
234 changes: 234 additions & 0 deletions apps/loopover-ui/public/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17522,6 +17522,240 @@
}
]
}
},
"/v1/repos/{owner}/{repo}/pulls/{number}/incident-reports": {
"post": {
"parameters": [
{
"schema": {
"type": "string"
},
"required": true,
"name": "owner",
"in": "path"
},
{
"schema": {
"type": "string"
},
"required": true,
"name": "repo",
"in": "path"
},
{
"schema": {
"type": "string"
},
"required": true,
"name": "number",
"in": "path"
}
],
"requestBody": {
"content": {
"application/json": {
"schema": {
"type": "object",
"properties": {
"description": {
"type": "string",
"minLength": 1,
"maxLength": 4000
},
"severity": {
"type": "string",
"enum": [
"low",
"medium",
"high",
"critical"
]
},
"mergedSha": {
"type": "string"
}
},
"required": [
"description",
"severity"
]
}
}
}
},
"responses": {
"200": {
"description": "Post-merge incident report recorded as an audit_events row (#5672), customer-facing (repo maintainer) side",
"content": {
"application/json": {
"schema": {
"type": "object",
"properties": {
"ok": {
"type": "boolean",
"enum": [
true
]
},
"repoFullName": {
"type": "string"
},
"pullNumber": {
"type": "number"
},
"id": {
"type": "string"
},
"createdAt": {
"type": "string"
}
},
"required": [
"ok",
"repoFullName",
"pullNumber",
"id",
"createdAt"
]
}
}
}
},
"400": {
"description": "Invalid pull number or incident report body"
},
"401": {
"description": "Unauthorized"
},
"403": {
"description": "Insufficient role"
},
"404": {
"description": "Pull request not found"
},
"409": {
"description": "Pull request has not been merged"
}
},
"security": [
{
"LoopOverBearer": []
},
{
"LoopOverSessionCookie": []
}
]
}
},
"/v1/app/incident-reports": {
"post": {
"requestBody": {
"content": {
"application/json": {
"schema": {
"type": "object",
"properties": {
"repoFullName": {
"type": "string",
"minLength": 3,
"maxLength": 200
},
"pullNumber": {
"type": "integer",
"minimum": 0,
"exclusiveMinimum": true
},
"description": {
"type": "string",
"minLength": 1,
"maxLength": 4000
},
"severity": {
"type": "string",
"enum": [
"low",
"medium",
"high",
"critical"
]
},
"mergedSha": {
"type": "string"
}
},
"required": [
"repoFullName",
"pullNumber",
"description",
"severity"
]
}
}
}
},
"responses": {
"200": {
"description": "Post-merge incident report recorded as an audit_events row (#5672), internal-operator side",
"content": {
"application/json": {
"schema": {
"type": "object",
"properties": {
"ok": {
"type": "boolean",
"enum": [
true
]
},
"repoFullName": {
"type": "string"
},
"pullNumber": {
"type": "number"
},
"id": {
"type": "string"
},
"createdAt": {
"type": "string"
}
},
"required": [
"ok",
"repoFullName",
"pullNumber",
"id",
"createdAt"
]
}
}
}
},
"400": {
"description": "Invalid incident report body"
},
"401": {
"description": "Unauthorized"
},
"403": {
"description": "Insufficient app role (operator only)"
},
"404": {
"description": "Pull request not found"
},
"409": {
"description": "Pull request has not been merged"
}
},
"security": [
{
"LoopOverBearer": []
},
{
"LoopOverSessionCookie": []
}
]
}
}
},
"servers": [
Expand Down
90 changes: 90 additions & 0 deletions src/api/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ import {
listAuditEventsForTarget,
listPendingAgentActions,
recordAuditEvent,
recordPostMergeIncidentReport,
getContributorEvidence,
getProductUsageRollupStatus,
listAllPullRequestDetailSyncStates,
Expand Down Expand Up @@ -890,6 +891,32 @@ const digestSubscriptionSchema = z
})
.strict();

const postMergeIncidentSeveritySchema = z.enum(["low", "medium", "high", "critical"]);

const postMergeIncidentReportSchema = z
.object({
description: z.string().min(1).max(4000),
severity: postMergeIncidentSeveritySchema,
mergedSha: z
.string()
.regex(/^[0-9a-f]{7,40}$/i)
.optional(),
})
.strict();

const operatorPostMergeIncidentReportSchema = z
.object({
repoFullName: z.string().min(3).max(200),
pullNumber: z.number().int().positive(),
description: z.string().min(1).max(4000),
severity: postMergeIncidentSeveritySchema,
mergedSha: z
.string()
.regex(/^[0-9a-f]{7,40}$/i)
.optional(),
})
.strict();

function contributorOpenIssueCount(issues: Array<{ repoFullName: string; state: string }>, repoFullName: string): number {
const targetRepo = repoFullName.toLowerCase();
return issues.filter((issue) => issue.repoFullName.toLowerCase() === targetRepo && issue.state === "open").length;
Expand Down Expand Up @@ -1655,6 +1682,34 @@ export function createApp() {
return c.json({ ok: true, ...verified });
});

// #5672 post-merge incident report, internal-operator side: same reporting path as the repo-scoped customer
// route (POST /v1/repos/:owner/:repo/pulls/:number/incident-reports), for an operator filing on a customer's
// behalf. Not scoped to one repo's session, so repoFullName/pullNumber travel in the body instead of the path.
app.post("/v1/app/incident-reports", async (c) => {
const forbidden = await requireAppRole(c, ["operator"]);
if (forbidden) return forbidden;
const identity = await authenticateRequestIdentity(c);
/* v8 ignore next -- requireAppRole already rejects an unauthenticated caller before this handler runs. */
if (!identity) return c.json({ error: "unauthorized" }, 401);
const body = await c.req.json().catch(() => null);
const parsed = operatorPostMergeIncidentReportSchema.safeParse(body);
if (!parsed.success) return c.json({ error: "invalid_incident_report", issues: parsed.error.issues }, 400);
const pullRequest = await getPullRequest(c.env, parsed.data.repoFullName, parsed.data.pullNumber);
if (!pullRequest) return c.json({ error: "pull_request_not_found" }, 404);
if (!pullRequest.mergedAt) return c.json({ error: "pull_request_not_merged" }, 409);
const report = await recordPostMergeIncidentReport(c.env, {
repoFullName: parsed.data.repoFullName,
pullNumber: parsed.data.pullNumber,
description: parsed.data.description,
severity: parsed.data.severity,
mergedSha: parsed.data.mergedSha,
reporterKind: "operator",
actor: identity.actor,
route: c.req.path,
});
return c.json({ ok: true, repoFullName: parsed.data.repoFullName, pullNumber: parsed.data.pullNumber, ...report });
});

app.get("/v1/app/notification-model", async (c) => {
const forbidden = await requireAppRole(c, ["maintainer", "owner", "operator"]);
if (forbidden) return forbidden;
Expand Down Expand Up @@ -2517,6 +2572,36 @@ export function createApp() {
return c.json({ repoFullName: fullName, events: events.map((event) => ({ ...event, detail: event.detail === null ? null : sanitizePublicComment(event.detail) })) });
});

// #5672 post-merge incident report, customer-facing side: a repo maintainer reports that an already-merged
// rented-loop PR was found harmful. Persists as an audit_events row keyed to this PR (same targetKey the
// audit-feed route above reads back via ?pull=N), so no separate incident table/read-route is needed here.
app.post("/v1/repos/:owner/:repo/pulls/:number/incident-reports", async (c) => {
const fullName = `${c.req.param("owner")}/${c.req.param("repo")}`;
const gate = await requireRepoMaintainer(c, fullName);
/* v8 ignore next -- unauthorized requests are rejected by the auth middleware before reaching the handler. */
if (gate instanceof Response) return gate;
const pullNumber = Number(c.req.param("number"));
if (!Number.isInteger(pullNumber) || pullNumber <= 0) return c.json({ error: "invalid_pull_number" }, 400);
const body = await c.req.json().catch(() => null);
const parsed = postMergeIncidentReportSchema.safeParse(body);
if (!parsed.success) return c.json({ error: "invalid_incident_report", issues: parsed.error.issues }, 400);
const pullRequest = await getPullRequest(c.env, fullName, pullNumber);
if (!pullRequest) return c.json({ error: "pull_request_not_found" }, 404);
if (!pullRequest.mergedAt) return c.json({ error: "pull_request_not_merged" }, 409);
const actor = gate.identity?.kind === "session" ? gate.identity.actor : "maintainer";
const report = await recordPostMergeIncidentReport(c.env, {
repoFullName: fullName,
pullNumber,
description: parsed.data.description,
severity: parsed.data.severity,
mergedSha: parsed.data.mergedSha,
reporterKind: "customer",
actor,
route: c.req.path,
});
return c.json({ ok: true, repoFullName: fullName, pullNumber, ...report });
});

// Maintainer activation demo (#701): a repo-specific "here's what LoopOver would have surfaced" preview
// over recent PRs, plus a one-click advisory ramp. Maintainer-scoped + per-repo. Deterministic (no AI run).
app.get("/v1/repos/:owner/:repo/activation-preview", async (c) => {
Expand Down Expand Up @@ -5416,6 +5501,7 @@ function canSessionAccessPath(env: Env, identity: Extract<AuthIdentity, { kind:
if (isRepoValidateLinkedIssuePath(path)) return true;
if (isRepoAgentAuditFeedPath(path)) return true; // route's requireRepoMaintainer enforces per-repo authority (contributors → 403)
if (isRepoAgentPendingActionsPath(path)) return true; // list-only: requireRepoMaintainer; decision POSTs require server tokens
if (isRepoIncidentReportsPath(path)) return true; // #5672: route's requireRepoMaintainer enforces per-repo authority (contributors → 403)
if (isRepoContributorIssueDraftGeneratePath(path)) return true;
if (path === OPPORTUNITIES_FIND_PATH) return true;
if (path === ISSUE_RAG_RETRIEVE_PATH) return true;
Expand Down Expand Up @@ -5471,6 +5557,10 @@ function isRepoAgentAuditFeedPath(path: string): boolean {
return /^\/v1\/repos\/[^/]+\/[^/]+\/agent\/audit-feed$/.test(path);
}

function isRepoIncidentReportsPath(path: string): boolean {
return /^\/v1\/repos\/[^/]+\/[^/]+\/pulls\/[^/]+\/incident-reports$/.test(path);
}

function isRepoAgentPendingActionsPath(path: string): boolean { return /^\/v1\/repos\/[^/]+\/[^/]+\/agent\/pending-actions$/.test(path); }
function isIssueQualityPath(path: string): boolean {
return /^\/v1\/repos\/[^/]+\/[^/]+\/issue-quality$/.test(path);
Expand Down
Loading
Loading