docs(miner): AMS auth/identity research — hosted login-layer options - #5764
Conversation
Research spike (JSONbored#5217): surveys auth/identity approaches for a hosted, multi-tenant AMS, evaluated against the installation-token / GitHub App patterns gittensory already operates (ORB's token-broker src/orb/broker.ts das-github-mirror exchange + src/orb/oauth.ts maintainer-OAuth self-enrollment). Compares (1) GitHub OAuth reusing the existing self-enrollment + broker, (2) a managed identity provider alongside the broker, (3) a custom JWT/OIDC scheme, each with security + integration tradeoffs and explicit reuse/replace/alongside notes for the broker's token exchange. Recommends GitHub-OAuth-as-identity reusing the broker; IdP only for non-GitHub tenants; custom JWT/OIDC avoided. Research/writeup only, non-binding, no code changed. Closes JSONbored#5217
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-14 13:02:12 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 5 non-blocking
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Closes #5217. (Clean resubmit of the closed #5763 — that branch was cut from a stale base and accidentally bundled the already-merged #5216 storage doc; this PR touches exactly one file, the #5217 deliverable.)
A research-spike comparison doc (
packages/loopover-miner/docs/ams-auth-identity-research.md) surveying hosted-AMS auth/identity options, grounded in ORB's existing GitHub-App token-broker precedent (src/orb/broker.tsdas-github-mirror model,src/orb/oauth.tsself-enrollment) vs the miner'sGITHUB_TOKEN-env no-auth baseline.Compares 3 approaches — (1) GitHub OAuth reusing the self-enrollment + broker (recommended), (2) managed IdP alongside, (3) custom JWT/OIDC — each with security/integration tradeoffs and explicit reuse/replace/alongside notes for the broker's token exchange. Docs-only, non-binding, no code changed (per the issue boundaries).