fix(review): scope ops-scan, self-tune, and maintainer-recap by isInstalled - #5702
Conversation
…talled opsScanRepos (ops-wire.ts), selfTuneRepos (selftune-wire.ts), and recapScanRepos (maintainer-recap-wire.ts) all filtered their candidate repo list on repo.isRegistered before narrowing further to agent-configured repos. Each function's own doc comment claims to mirror fanOutAgentRegateSweepJobs's repo population (the actual re-gate sweep), but that function has no isRegistered filter at all -- it sweeps every review-active (allowlisted or webhook-installed) repo. The data these three functions operate on (gate false-positive rate, slop-score calibration, review-burst detection, gate self-tuning confidence floor, PR/issue backlog digests) is core review-quality monitoring for any repo the review agent actually runs the gate on -- unrelated to gittensor-subnet registry membership. An installed-but-unregistered self-host repo was silently excluded from ops anomaly monitoring, self-tune calibration, and the maintainer recap digest even though the review agent was actively gating PRs on it. Found via the epic #5016 isRegistered/isInstalled exhaustive audit, adversarially verified against 6 other candidates that turned out to be legitimately subnet-specific (decision-pack/scoring semantics) and were left unchanged. Advances #5016
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5702 +/- ##
=======================================
Coverage 95.04% 95.04%
=======================================
Files 578 578
Lines 46064 46064
Branches 14738 14738
=======================================
Hits 43781 43781
Misses 1524 1524
Partials 759 759
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-14 05:42:19 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 3 non-blocking
Concerns raised — review before merging
📋 Copy for AI agents — paste into your coding agent
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
opsScanRepos(src/review/ops-wire.ts),selfTuneRepos(src/review/selftune-wire.ts), andrecapScanRepos(src/review/maintainer-recap-wire.ts) all filtered their candidate repo list onrepo.isRegisteredbefore narrowing further to agent-configured repos.fanOutAgentRegateSweepJobs's repo population (the actual re-gate sweep), but that function has noisRegisteredfilter at all — it sweeps every review-active (allowlisted or webhook-installed) repo.isRegistered/isInstalledexhaustive audit. Adversarially verified (2 independent verifiers per candidate, reading real call chains) against 6 other candidates from the same sweep that turned out to be legitimately subnet-specific (decision-pack/scoring semantics:refreshContributorActivity,buildContributorOpportunities,buildContributorFit,processContributorEvidenceLogins,loadIssueQualityReportMap,evidenceGraphTouchedRepoFullNames) and were correctly left unchanged.Test plan
#5016positive regression (installed-not-registered included) + negative regression (registered-not-installed excluded) for all 3 functions (6 new tests total)test/unit/ops-wire.test.ts+test/unit/selftune-wiring.test.ts+test/unit/maintainer-recap-wire.test.ts+test/unit/selfhost-queue-common.test.ts— 174/174 passednpm run test:ci+npm audit --audit-level=moderate) green: 829 test files passed, 0 failedAdvances #5016