Skip to content

fix(signals): scope contributor-open-pr-monitor to isInstalled, not isRegistered - #5691

Merged
JSONbored merged 1 commit into
mainfrom
fix/open-pr-monitor-isinstalled-5025
Jul 14, 2026
Merged

fix(signals): scope contributor-open-pr-monitor to isInstalled, not isRegistered#5691
JSONbored merged 1 commit into
mainfrom
fix/open-pr-monitor-isinstalled-5025

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • buildContributorOpenPrMonitor scoped a contributor's open-PR "next steps" packet to isRegistered repos.
  • Every field it produces (classification, reasons, next steps, guidance) is generic PR-hygiene advice with zero gittensor-specific data — no reward-risk, no decision-pack fields.
  • Product decision made on Product decision: contributor-open-pr-monitor scope for self-host #5025: option (b), scoped to isInstalled — with the architectural note that gittensor-specific enrichment should be additive-plugin, not base-then-stripped. Since this endpoint carries no gittensor-specific fields today, that principle is already satisfied without any field-trimming: gittensor never added anything here in the first place.
  • Field name registeredRepoCount deliberately left unchanged (now counts installed repos) — its rename is explicitly sequenced into Dashboard 'registered vs installed' copy audit #5026 (dashboard "registered vs installed" copy audit), which the issue's own dependency chain says should land last, once the split is accurate everywhere.

Test plan

  • Updated existing test to reflect new isInstalled-scoping (previously asserted the isRegistered-only behavior)
  • New regression test: installed-but-not-subnet-registered repo is now covered
  • npm run test:ci — full local gate, clean (0 failures)

Closes #5025

…sRegistered

buildContributorOpenPrMonitor scoped a contributor's open-PR "next steps"
packet to isRegistered repos. Every field it produces (classification,
reasons, next steps, guidance) is generic PR-hygiene advice with zero
gittensor-specific data (no reward-risk, no decision-pack fields), so
per the product decision on #5025, it's now available for any self-host
operator's installed repos regardless of gittensor-subnet opt-in status
-- consistent with #5021/#5022/#5024's isRegistered->isInstalled fixes.

Since no gittensor-specific fields exist on this endpoint today, no
field-trimming was needed: gittensor stays a pure additive plugin here
by not having added anything to this surface in the first place.

Closes #5025
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.02%. Comparing base (21d13b2) to head (05eeb10).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5691   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         577      577           
  Lines       45978    45978           
  Branches    14724    14724           
=======================================
  Hits        43689    43689           
  Misses       1530     1530           
  Partials      759      759           
Flag Coverage Δ
shard-1 43.63% <100.00%> (-0.43%) ⬇️
shard-2 35.84% <0.00%> (+0.06%) ⬆️
shard-3 32.33% <100.00%> (-0.09%) ⬇️
shard-4 33.04% <100.00%> (-0.02%) ⬇️
shard-5 31.51% <100.00%> (-0.26%) ⬇️
shard-6 44.62% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/signals/contributor-open-pr-monitor.ts 96.22% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 14, 2026
@loopover-orb

loopover-orb Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-14 05:34:24 UTC

2 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a narrow, well-scoped one-line semantic fix: changes the repo filter in buildContributorOpenPrMonitor from isRegistered to isInstalled, consistent with the described migration pattern (#5021/#5022/#5024) and the product decision on #5025. The PR correctly identifies that this monitor produces no gittensor-specific fields (just generic PR-hygiene classification/next-steps), so scoping to isInstalled is the right layer for the fix rather than any downstream filtering. Tests are updated to reflect the new scoping and a new regression test covers the installed-but-not-subnet-registered case, closing #5025 as claimed.

Nits — 5 non-blocking
  • src/signals/contributor-open-pr-monitor.ts: the variable name `registered` (and `registeredRepoCount` field) now actually track installed repos, which is a stale name deliberately left for Dashboard 'registered vs installed' copy audit #5026 per the PR description, but it's worth flagging so reviewers don't miss the semantic mismatch during interim reads.
  • summarizeMonitor and buildMonitorGuidance still say 'registered repos' in user-facing summary strings even though the underlying set is now isInstalled-scoped, which could surface accurate-looking but semantically wrong copy to self-host operators until Dashboard 'registered vs installed' copy audit #5026 lands.
  • Consider a short-lived comment near `registeredRepoCount` in the type definition (not just the filter line) noting the rename is deferred to Dashboard 'registered vs installed' copy audit #5026, so downstream consumers of this field aren't misled.
  • If low-effort, align the summary/guidance string wording ('registered repos') with 'installed repos' now, since that's user-visible text, even though the field name itself is intentionally deferred.
  • PR author also opened the linked issue — Link an issue that was opened by a different contributor, or provide a rationale for why this self-authored issue represents genuine discovery work.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #5025
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 45 registered-repo PR(s), 37 merged, 320 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 45 PR(s), 320 issue(s).
Gate result ✅ Passing No configured blocker found.
Improvement ✅ Minor risk: clean · value: minor — Code changes are accompanied by test evidence.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, TypeScript, Ruby, Go, JavaScript, MDX, Shell, Solidity
  • Official Gittensor activity: 45 PR(s), 320 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 14, 2026
@JSONbored
JSONbored merged commit 1c7c771 into main Jul 14, 2026
17 checks passed
@JSONbored
JSONbored deleted the fix/open-pr-monitor-isinstalled-5025 branch July 14, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Product decision: contributor-open-pr-monitor scope for self-host

1 participant