feat(observability): cross-link the AMS miner-usage dashboard from the resource hub - #5647
Closed
JSONbored wants to merge 2 commits into
Closed
feat(observability): cross-link the AMS miner-usage dashboard from the resource hub#5647JSONbored wants to merge 2 commits into
JSONbored wants to merge 2 commits into
Conversation
…ost, and attempt outcomes Adds grafana/dashboards/miner-usage.json: a single dashboard (a $provider template variable, not one dashboard per provider) showing per-provider attempt success/fail counts, total cost, and total tokens, reading only the redacted attempt_outcome_summary rows the AMS reporting export exposes via the AMS Attempt Log SQLite datasource -- no Prometheus scraping. Cross-references ai-usage.json (ORB) in both directions via a top-level `links` entry, matching the only existing dashboard-to- dashboard link convention in this repo (resource-hub.json's own links array). ai-usage.json's other panels/variables are untouched.
…e resource hub Adds a "Miner usage (AMS)" bullet to resource-hub.json's existing "Observability & dashboards" markdown panel, right after "AI usage" -- same bullet style, matching the hub's own established pattern for cross-linking other integrated dashboards. Additive only: the "Integrated services" panel and every other panel/datasource/variable in the hub are untouched.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Owner
Author
|
Superseded: #5189 was independently implemented and merged via #5640 while this PR was open (a different, equally valid approach — a dedicated AMS panel linking to the observability guide, vs. this PR's bullet-in-existing-panel approach). Closing as duplicate; the conflicts are with #5640's already-merged panel addition, not worth resolving for redundant work. |
loopover-orb
Bot
added
the
gittensor:bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5647 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 577 577
Lines 45920 45920
Branches 14695 14695
=======================================
Hits 43640 43640
Misses 1528 1528
Partials 752 752
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #5646 (needs
grafana/dashboards/miner-usage.jsonto exist — this PR's base branch is #5646's branch, notmain, so the diff shown here is scoped to just this change; it'll retargetmainautomatically once #5646 merges).**[Miner usage (AMS)](/d/loopover-miner-usage)**bullet toresource-hub.json's existing "Observability & dashboards" markdown panel, immediately after the "AI usage" bullet — matching that panel's exact established- **[Title](/d/uid)** — note.style (same panel type, same markdown-list convention every other cross-linked dashboard in that panel already uses).gittensory-miner) is a separate local CLI, worth checking if you're also running it alongside ORB.Visual verification (real Grafana, not just JSON validation)
Spun up a real local
grafana/grafana:13.1.0container withgrafana/dashboards+grafana/provisioning/dashboardsmounted (no other services — this only needed dashboard auto-provisioning, not live data) and confirmed live in a browser:Integrated servicespanel is visually unchanged./d/loopover-miner-usageresolves to the real miner-usage dashboard (page title confirms "LoopOver — Miner usage (AMS)") — the link target is not a dead/typo'd path.(Not attaching the actual screenshot files to this PR body — no straightforward CLI path to embed local images in a
gh pr createbody — but the verification above was performed against a real running instance, not asserted from the JSON alone.)Test plan
npm run selfhost:validate-observabilitytest/unit/selfhost-grafana-resource-hub-dashboard.test.ts(6 cases): structural validator pass, exactly one new bullet added (no new panel/panel-type),Integrated servicespanel byte-unchanged, the linked/d/<uid>resolves tominer-usage.json's realuid(catches a typo'd path), the AMS note is present and reasonably short, and the bullet sits immediately after "AI usage" (not appended out of place)npm run typecheckgit diff --checkCloses #5189