feat(miner-extension): add workspace package and CI wiring - #5567
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5567 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 573 573
Lines 45469 45469
Branches 14680 14680
=======================================
Hits 43187 43187
Misses 1531 1531
Partials 751 751
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-13 06:38:56 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 6 non-blocking
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
5423508 to
a3fc9c4
Compare
Add package.json for gittensory-miner-extension and gittensory-extension, register both as npm workspaces, add build/lint/typecheck scripts and CI steps matching the maintainer extension, and extend lockfile with workspace entries only so npm ci stays in sync. Closes JSONbored#4866 Co-authored-by: Cursor <cursoragent@cursor.com>
a3fc9c4 to
ac21fc8
Compare
JSONbored
left a comment
There was a problem hiding this comment.
Closing:
package-lock.json (diff) removes top-level entries for @cloudflare/workers-types and @anthropic-ai/sdk and re-marks several previously non-dev packages (e.g. @emnapi/core, postcss, rolldown, nanoid) as dev:true — this is unrelated lockfile drift for a PR that should only be adding two new workspace packages, and is a plausible root cause for validate-code and validate-tests failing across every shard on this commit; regenerate the lockfile from a clean `npm install` against main rather than committing whatever state the local tree produced.
PR #5567 added `npm --workspace @jsonbored/gittensory-miner-ui run build` to the ui:build script chain, but gittensory-miner-ui's vite config transitively dynamic-imports @jsonbored/gittensory-miner's portfolio-dashboard.js (via vite-portfolio-queue-api.ts), which depends on @jsonbored/gittensory-engine. ui:build never builds the engine first, so its dist/ doesn't exist and vite's config bundler fails: "Failed to resolve entry for package '@jsonbored/gittensory- engine'". This worked by accident in `npm run test:ci` (an earlier step, build:miner, happens to build the engine first in that chain) but fails standalone wherever ui:build runs in isolation — confirmed via ui-preview.yml failing identically on this branch and on an unrelated renovate/npm-minor-patch branch at the same time, meaning it's been broken on main for every PR touching apps/gittensory-ui/** or packages/** since #5567 merged. ui:lint and ui:typecheck are unaffected: TS/ESLint resolve @jsonbored/gittensory-engine via tsconfig path-mapping to source, not the compiled package entry.
Summary
Closes #4866
Test plan