Skip to content

refactor(actions): rename visual-capture-fallback.yml workflow name, env vars, and artifact to loopover - #5534

Merged
JSONbored merged 1 commit into
mainfrom
loopover/visual-fallback-yml
Jul 13, 2026
Merged

refactor(actions): rename visual-capture-fallback.yml workflow name, env vars, and artifact to loopover#5534
JSONbored merged 1 commit into
mainfrom
loopover/visual-fallback-yml

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

Renames .github/workflows/visual-capture-fallback.yml's cross-repo contract surface: the workflow's declared name: ("Gittensory Visual Capture Fallback" -> "LoopOver Visual Capture Fallback"), its four internal env vars (GITTENSORY_DIST_DIR/_SERVE_PORT/_ROUTES_JSON/_BUILD_CMD -> LOOPOVER_*), and the run-name/uploaded-artifact name ("gittensory-visual-fallback" -> "loopover-visual-fallback"). Updates src/review/visual/actions-fallback.ts's matching FALLBACK_WORKFLOW_NAME, FALLBACK_ARTIFACT_NAME, and RUN_NAME_PATTERN constants that dispatch this workflow and correlate its completion webhook.

Per explicit maintainer decision: hard cutover, no compatibility alias or grace period — no other self-hosted repos have adopted ORB yet, so there is no existing downstream copy of this workflow file that would break.

Deliberately unchanged

  • The actual filename visual-capture-fallback.yml and the FALLBACK_WORKFLOW_FILE constant — neither ever carried old-brand text, so there's nothing to rename there.
  • The R2 key namespace constants in this same file (FALLBACK_SHOT_NAMESPACE, FALLBACK_DISPATCH_MARKER_NAMESPACE) — already renamed by the separate, now-merged R2 bucket migration (2 live buckets) and the public /gittensory/shot route #5332 (R2 bucket migration) PR.
  • .gittensory.yml.example's reference to this workflow — it only names the (unchanged) filename, no stale content to fix.

Test plan

  • Full npm run test:ci gate green (typecheck, coverage, engine-parity, mcp/miner builds, UI lint/typecheck/test/build, actionlint).
  • Fixed 2 test files (actions-fallback.test.ts, actions-fallback-webhook.test.ts — 79 tests) whose fixtures asserted the old workflow name/artifact/run-name strings.
  • Repo-wide sweep confirms no stray reference to the old workflow name, env vars, or artifact name remains outside deliberately-unchanged categories.

Closes #5338.

…env vars, and artifact to loopover

Renames the cross-repo contract's workflow name ("Gittensory Visual Capture
Fallback" -> "LoopOver Visual Capture Fallback"), its four internal env vars
(GITTENSORY_DIST_DIR/SERVE_PORT/ROUTES_JSON/BUILD_CMD -> LOOPOVER_*), the
run-name/artifact name ("gittensory-visual-fallback" -> "loopover-visual-
fallback"), and the matching constants + run-name regex in
src/review/visual/actions-fallback.ts that dispatch and correlate it.

Per explicit maintainer decision: hard cutover, no compatibility alias or
grace period -- no other self-hosted repos have adopted ORB yet, so there is
no existing downstream copy of this workflow file to break.

The actual filename (visual-capture-fallback.yml) and FALLBACK_WORKFLOW_FILE
constant are unchanged, since neither ever carried old-brand text.

Closes #5338.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.79%. Comparing base (ff94e35) to head (40f4734).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5534   +/-   ##
=======================================
  Coverage   94.79%   94.79%           
=======================================
  Files         566      566           
  Lines       45065    45065           
  Branches    14675    14675           
=======================================
  Hits        42718    42718           
  Misses       1613     1613           
  Partials      734      734           
Flag Coverage Δ
shard-1 44.20% <100.00%> (ø)
shard-2 35.47% <100.00%> (ø)
shard-3 31.94% <100.00%> (ø)
shard-4 31.92% <100.00%> (ø)
shard-5 32.87% <100.00%> (+<0.01%) ⬆️
shard-6 43.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/review/visual/actions-fallback.ts 98.25% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 13, 2026
@loopover-orb

loopover-orb Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-13 04:04:08 UTC

4 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

⏸️ Suggested Action - Manual Review

  • Touches a guarded path — held for manual review: This PR changes guardrail-protected path(s): .github/workflows/visual-capture-fallback.yml (matched .github/workflows/**), src/review/visual/actions-fallback.ts (matched src/review/**).

Review summary
Consistent, mechanical rename of the visual-capture-fallback workflow's declared name, env vars, and artifact/run-name from Gittensory to LoopOver branding, with matching updates to the TS constants (FALLBACK_WORKFLOW_NAME, FALLBACK_ARTIFACT_NAME, RUN_NAME_PATTERN) that dispatch and correlate it, plus fixture updates in both test files. Every string pair in the workflow YAML (env var names, run-name, artifact name) and the corresponding regex/constants in actions-fallback.ts line up correctly, and the workflow's own doc comments were updated in lockstep so the setup instructions stay accurate. CI is green across typecheck, coverage, and actionlint, and the diff is narrowly scoped to the stated rename with no stray old-brand references left in the shown hunks.

Nits — 7 non-blocking
  • The PR description explicitly documents a maintainer decision to do a hard cutover with no compatibility alias for Rename the visual-capture-fallback.yml cross-repo contract with a compatibility alias #5338, even though the issue brief indicates the issue asked for a compatibility alias — worth double-checking that decision was actually approved and not just asserted by the contributor.
  • Confirm via repo-wide grep (as the test plan claims) that no other self-hosted repo config or docs still reference the old GITTENSORY_* env var names or gittensory-visual-fallback artifact name.
  • Since RUN_NAME_PATTERN's regex literal changed, double check no other module still imports or re-derives a hardcoded copy of the old pattern outside the files shown here.
  • nit: `.github/workflows/visual-capture-fallback.yml:26` still describes the backend and project using the old project name in comments; that is not part of the runtime contract, but for a branding cutover you should either leave a short reason in the PR or update the prose consistently.
  • nit: `test/unit/actions-fallback-webhook.test.ts:183` and the surrounding fixtures repeat the new workflow name/run-name literal many times; consider using shared fixture constants so the next contract rename does not require a broad mechanical test edit.
  • PR author also opened the linked issue — Link an issue that was opened by a different contributor, or provide a rationale for why this self-authored issue represents genuine discovery work.
  • Touches a guarded path — held for manual review — A maintainer must review and merge this change.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #5338
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 44 registered-repo PR(s), 36 merged, 399 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 44 PR(s), 399 issue(s).
Gate result ⚠️ Not blocking Advisory; not blocking this PR.
Improvement ✅ Minor risk: clean · value: minor — Code changes are accompanied by test evidence.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, TypeScript, Ruby, Go, JavaScript, MDX, Shell, Solidity
  • Official Gittensor activity: 44 PR(s), 399 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 13, 2026
@JSONbored
JSONbored merged commit 851234c into main Jul 13, 2026
17 checks passed
@JSONbored
JSONbored deleted the loopover/visual-fallback-yml branch July 13, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename the visual-capture-fallback.yml cross-repo contract with a compatibility alias

1 participant