feat!: remove gittensory-engine's settings.gateCheckMode yml back-compat parsing (#5373) - #5463
Merged
JSONbored merged 1 commit intoJul 12, 2026
Conversation
…pat parsing (#5373) Final stage of the gateCheckMode removal (stage 2.10/2.10): the RepositorySettings field itself was removed in #5459, but @jsonbored/gittensory-engine's own .gittensory.yml parser still recognized a bare settings.gateCheckMode key and derived reviewCheckMode from it for back-compat. Remove that derivation, the FocusManifestSettings type entry, and the deprecated field on manifest-deps-types.ts's RepositorySettings mirror. settings.gateCheckMode is now an unrecognized key: it parses into nothing and derives nothing. settings.reviewCheckMode remains the sole, unambiguous publish-authority key. Blast radius: parseFocusManifest/parseFocusManifestContent are the only public exports touched. @jsonbored/gittensory-mcp doesn't reference this code path at all; @jsonbored/gittensory-miner calls parseFocusManifestContent but never reads gateCheckMode/ reviewCheckMode from the result, and isn't itself published to npm. publish-engine.yml is workflow_dispatch-only, so merging this does not itself publish anything. The package.json version is already 1.0.0 (#4686, merged, not yet published -- npm still serves 0.2.0) -- bundling this breaking removal into that not-yet-shipped 1.0.0 is the right time to shed this back-compat parsing before the package commits to a stable surface, rather than requiring a separate future major bump for the same change. Also drops a now-dead SETTINGS_ALIAS_MANIFEST row in check-docs-drift.mjs left over from the RepositorySettings-level removal in #5459 (gateCheckMode is no longer iterated as a field to alias-check at all).
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 0397826 | Commit Preview URL Branch Preview URL |
Jul 12 2026, 09:06 PM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5463 +/- ##
==========================================
- Coverage 94.52% 94.52% -0.01%
==========================================
Files 554 554
Lines 44469 44466 -3
Branches 14666 14664 -2
==========================================
- Hits 42034 42031 -3
Misses 1754 1754
Partials 681 681
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JSONbored
deleted the
chore/gatecheckmode-engine-yml-backcompat-stage2-10
branch
July 12, 2026 21:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final stage (2.10 of 10) of the
gateCheckModeremoval (#5373). TheRepositorySettings.gateCheckModefield itself was removed entirely in #5459 (stage 2.9). This PR removes the last remaining vestige:@jsonbored/gittensory-engine's own.gittensory.ymlparser (parseFocusManifest/parseFocusManifestContent) still recognized a baresettings.gateCheckModekey and derivedreviewCheckModefrom it for back-compat with older manifest files.packages/gittensory-engine/src/focus-manifest.ts: removed thegateCheckModeparse + derive-reviewCheckMode-when-unset logic fromparseSettingsOverride; removed"gateCheckMode"from theFocusManifestSettingsPick<RepositorySettings, ...>list; rewrote theFocusManifestGateConfigdoc comment (fixed a stale "master switch" claim while in the area).packages/gittensory-engine/src/types/manifest-deps-types.ts: removed the deprecatedgateCheckMode?: "off" | "enabled"field from the engine's ownRepositorySettingsmirror type.scripts/check-docs-drift.mjs: dropped a now-deadSETTINGS_ALIAS_MANIFESTrow forgateCheckMode— it's no longer iterated as aRepositorySettingsfield, so the alias entry was orphaned since feat!: remove the gateCheckMode field from RepositorySettings entirely #5459.test/unit/focus-manifest.test.ts(rewrote thesettings.gateCheckModeback-compat describe block into a "fully removed, inert key" regression suite; removed the deadSETTINGS_GATE_ALIASED_FIELDSentry) andtest/unit/gate-check-policy.test.ts(updated one assertion that expected the now-removed derivation).settings.gateCheckModeis now a fully unrecognized key: it parses into nothing and derives nothing.settings.reviewCheckModeis the sole publish-authority key.Blast radius / why this is safe to merge now
parseFocusManifest/parseFocusManifestContentare the only public exports touched.@jsonbored/gittensory-mcp(published, v0.7.0 live) doesn't reference this code path at all.@jsonbored/gittensory-minercallsparseFocusManifestContentbut never readsgateCheckMode/reviewCheckModefrom the result, and isn't itself published to npm (git-clone-only)..github/workflows/publish-engine.ymlisworkflow_dispatch-only — merging this does not itself publish anything to the registry.packages/gittensory-engine/package.jsonis already at"1.0.0"(chore(release): cut engine v1.0.0 #4686, merged 2026-07-10, not yet published — npm registry still serves0.2.0). Bundling this breaking removal into that not-yet-shipped 1.0.0 is the right timing: it sheds this back-compat parsing before the package commits to a stable public surface, rather than requiring a separate major bump later for the same change. No publish is triggered by this PR.Test plan
npm run build --workspace @jsonbored/gittensory-engine— cleannpm run typecheck— clean (full monorepo)npx vitest run— full suite, 778 files / 15218 tests passed, 12 skipped, exit 0npm test --workspace @jsonbored/gittensory-engine(node:test) — 526/526 passingnpm run manifest:drift-check/engine-parity:drift-check/docs:drift-check— all cleannpm run ui:lint/npm run ui:typecheck— clean (pre-existing unrelated warnings only)npm audit --audit-level=moderate— 0 vulnerabilitiesgateCheckModereferences outside historical comments and regression tests asserting the key is now inertCloses #5373