chore(activation): replace gateCheckMode with reviewCheckMode on the maintainer-activation surface

[JSONbored]

Summary

Stage 2.8 of #5373's staged removal plan.

• Removes currentGateMode (MaintainerActivationPreview) and the gateCheckMode passthrough on the POST /activation response, replacing both with a reviewCheckMode-based equivalent instead of dropping the information outright -- reviewCheckMode is strictly more informative (required/visible/disabled vs. the old off/enabled) and was already the real value driving the recommendedAction/currentlyActive decision; gateCheckMode was purely a display echo that never affected any logic in buildMaintainerActivationPreview.
• Updates the UI (activation-preview.tsx's "gate {…}" status pill and its local response type) to match.
• Rewrites the #2852 legacy-yml-mismatch regression test: gateCheckMode/reviewCheckMode can no longer diverge on this surface since the display field is reviewCheckMode now, so the test keeps its real invariant (recommendedAction follows reviewCheckMode only, regardless of any other setting) without the now-meaningless gateCheckMode echo.

Test plan

• npm run typecheck
• npm run ui:typecheck
• npm run ui:lint
• npm run docs:drift-check
• test/unit/maintainer-activation.test.ts, test/integration/maintainer-activation.test.ts -- 19/19
• UI activation-preview test suite -- 7/7

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	gittensory-ui	987e547	Commit Preview URL Branch Preview URL	Jul 12 2026, 08:06 PM

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.44%. Comparing base (65fa28b) to head (987e547).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5455      +/-   ##
==========================================
- Coverage   94.48%   94.44%   -0.04%     
==========================================
  Files         554      554              
  Lines       44450    44450              
  Branches    14663    14663              
==========================================
- Hits        41999    41982      -17     
- Misses       1776     1793      +17     
  Partials      675      675              

Flag	Coverage Δ
shard-1	43.83% <ø> (-0.27%)	⬇️
shard-2	34.92% <ø> (-0.03%)	⬇️
shard-3	31.68% <ø> (-0.29%)	⬇️
shard-4	31.36% <ø> (+0.09%)	⬆️
shard-5	33.25% <ø> (-0.06%)	⬇️
shard-6	43.76% <ø> (+0.18%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/api/routes.ts	94.30% <ø> (ø)
src/services/maintainer-activation.ts	100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-12 20:10:54 UTC}

6 files · 1 AI reviewer · 1 blocker · readiness 100/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This PR mechanically replaces the deprecated gateCheckMode display field with reviewCheckMode across the maintainer-activation preview service, the /activation response, the UI status pill, and their corresponding tests, matching the described staged-removal work from #5373. The core claim checks out against the existing repository-settings test file shown in context: gateCheckMode is already a computed read-back derived from reviewCheckMode and never a write input, so this is purely a display-layer field swap with no logic change in buildMaintainerActivationPreview. The rewritten #2852 regression test correctly narrows to the real invariant (recommendedAction follows reviewCheckMode only) since the two fields can no longer diverge once currentGateMode is removed.

Nits — 5 non-blocking

• apps/gittensory-ui/.../activation-preview.tsx:25 the status pill label still reads "gate {preview.currentReviewCheckMode}" — since gateCheckMode terminology is being retired, consider relabeling the pill text (e.g. "review check {mode}") for clarity, though this is purely cosmetic.
• src/api/routes.ts:2554 confirm no other route or consumer still expects gateCheckMode in the /activation response body, since this diff only removes it from this one handler.
• Consider a follow-up doc/changelog note pointing at Stage and remove the derived-only gateCheckMode field (naming sprawl, #5355 follow-up) #5373 stage tracking so future stages know gateCheckMode is fully gone from this surface.
• nit: apps/gittensory-ui/src/components/site/app-panels/activation-preview.tsx:140 still renders the label as `gate {preview.currentReviewCheckMode}`, which is technically backed by reviewCheckMode now and may confuse maintainers seeing `gate visible` or `gate required`.
• apps/gittensory-ui/src/components/site/app-panels/activation-preview.tsx:140: consider changing the pill copy to `review {preview.currentReviewCheckMode}` or `check {preview.currentReviewCheckMode}` so the UI no longer names the removed legacy concept.

Concerns raised — review before merging

• No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

📋 Copy for AI agents — paste into your coding agent

Fix the following blocker(s) from this PR review:

1. No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

Signal	Result	Evidence
Code review	❌ 1 blocker	1 reviewer
Linked issue	✅ No-issue rationale	PR body explains why no issue is linked.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 44 registered-repo PR(s), 36 merged, 457 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 44 PR(s), 457 issue(s).
Gate result	❌ Blocking	Repo-configured hard blocker found.
Improvement	✅ Minor	risk: clean · value: minor — Code changes are accompanied by test evidence.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 44 PR(s), 457 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
• @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

Visual preview

Route	Viewport	Before (production)	After (this PR's preview)	Diff
/	desktop			—
/	mobile			—

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review