test: drop inert gateCheckMode fixture noise (#5373)

[JSONbored]

Summary

Stages 2.2-2.4 of #5373's staged removal plan, combined into one PR per this repo's own precedent for a uniform mechanical removal (#4012 merged an analogous 27-file field deletion in one shot).

Removes gateCheckMode from 22 test files where it appeared only as inert fixture noise -- a field set inside upsertRepositorySettings(...) calls, inline settings object literals, or fixture-builder helper functions, never read back or asserted on. Confirmed via the #5373 discovery audit and re-verified per-file by 3 independent isolated-worktree passes (one per sweep) before combining:

• Sweep A (8 files): linked-issue-satisfaction-run, actions-fallback-webhook, self-dogfood-registration-pack, policy-sanitizer, signals-v2, unified-comment-parity, ci-completion-fork-resume, repository-settings-enforcement
• Sweep B (8 files): safety, registration-readiness, repo-policy-readiness, signals, reputation-wiring, settings-preview, parity-wire, repo-profile
• Sweep C (6 files): queue, queue-2, queue-3, queue-4, queue-lifecycle-guards, signals-coverage

One deliberate exception found and left untouched by Sweep A: self-dogfood-registration-pack.test.ts has two gateCheckMode occurrences inside githubApp: {...} literals that satisfy GithubAppBehavior.gateCheckMode (src/signals/registration-readiness.ts) -- a separate, still-required type from RepositorySettings, not yet widened to optional. Removing those two would break typecheck; they're tracked for the next #5373 stage (registration-readiness/settings-preview response surfaces) instead.

(queue-5.test.ts's comparable fixture noise, discovered separately while investigating a DB-column-drop test failure, is already handled in #5446.)

Test plan

• npm run typecheck
• npm run docs:drift-check
• All 22 files run together: 1151/1151 tests pass

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.42%. Comparing base (e0c1000) to head (98f38d3).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5448      +/-   ##
==========================================
- Coverage   94.46%   94.42%   -0.04%     
==========================================
  Files         554      554              
  Lines       44438    44438              
  Branches    14663    14663              
==========================================
- Hits        41979    41962      -17     
- Misses       1784     1801      +17     
  Partials      675      675              

Flag	Coverage Δ
shard-1	43.84% <ø> (-0.27%)	⬇️
shard-2	34.91% <ø> (+0.04%)	⬆️
shard-3	31.69% <ø> (+0.10%)	⬆️
shard-4	31.35% <ø> (-0.06%)	⬇️
shard-5	32.88% <ø> (-0.39%)	⬇️
shard-6	43.83% <ø> (+0.46%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-12 19:58:52 UTC}

22 files · 2 AI reviewers · 2 blockers · readiness 93/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This is a purely mechanical test-fixture cleanup removing the unread `gateCheckMode` field from `upsertRepositorySettings(...)` calls, inline settings literals, and fixture helpers across 22 test files (stages 2.2-2.4 of #5373's staged removal plan), leaving CI green (typecheck, all 1151 tests, docs:drift-check) and correctly preserving the two `githubApp: { gateCheckMode }` occurrences in self-dogfood-registration-pack.test.ts that satisfy the still-required `GithubAppBehavior.gateCheckMode` type. The visible hunks consistently show only the field deletion with no other logic touched, matching the stated intent exactly, and the PR explicitly cites #4012 as repo precedent for combining a mechanical multi-file field removal into one PR.

Nits — 2 non-blocking

• The PR bundles three separately-swept batches (22 files) into one diff; while each hunk is trivially reviewable in isolation, a reviewer verifying the 'no other line changed' invariant across all 22 files has to trust the sweep methodology rather than re-derive it from the diff alone.
• Since Stage and remove the derived-only gateCheckMode field (naming sprawl, #5355 follow-up) #5373 tracks the staged removal, consider linking this PR number directly in the field's own deprecation comment (if one exists in the schema) so future greps don't need to rediscover the tracking issue.

Concerns raised — review before merging

• No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
• Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

📋 Copy for AI agents — paste into your coding agent

Fix the following blocker(s) from this PR review:

1. No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

2. Maintainer requires a linked issue — Link the relevant issue (for example `Closes #123`) before opening the PR.

Signal	Result	Evidence
Code review	❌ 2 blockers	2 reviewers, synthesized
Linked issue	⚠️ Missing	No linked issue or no-issue rationale found.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 44 registered-repo PR(s), 36 merged, 457 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 44 PR(s), 457 issue(s).
Gate result	❌ Blocking	Repo-configured hard blocker found.
Improvement	⚠️ ℹ️ Insufficient signal	risk: clean · value: insufficient-signal — Nothing measurable for the structural-improvement analyzers on this PR (e.g. no code files changed). LLM value judgment: minor — This is inert fixture-noise cleanup (dead field removal from test setup calls) that reduces test-file clutter but touches no production code or test behavior, consistent with the PR's own framing as one stage of a larger tracked cleanup rather than a standalone improvement.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 44 PR(s), 457 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.
• Explain no-issue PR.
• Link the issue being solved, or explicitly explain why this is a no-issue PR.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
• @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review