Skip to content

chore(types): widen gateCheckMode to optional, drop internal-only passthroughs #5440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 12, 2026
Merged

chore(types): widen gateCheckMode to optional, drop internal-only passthroughs #5440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions apps/gittensory-ui/public/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3911,7 +3911,6 @@
"commentMode",
"publicAudienceMode",
"checkRunMode",
"gateCheckMode",
"reviewCheckMode",
"quietByDefault",
"behavior",
Expand Down Expand Up @@ -9659,7 +9658,6 @@
"publicSignalLevel",
"checkRunMode",
"checkRunDetailLevel",
"gateCheckMode",
"regateSweepOrderMode",
"reviewCheckMode",
"gatePack",
Expand Down Expand Up @@ -9783,7 +9781,6 @@
"commentMode",
"publicAudienceMode",
"checkRunMode",
"gateCheckMode",
"reviewCheckMode",
"autoLabelEnabled"
]
Expand Down Expand Up @@ -10398,7 +10395,6 @@
"publicSignalLevel",
"checkRunMode",
"checkRunDetailLevel",
"gateCheckMode",
"regateSweepOrderMode",
"reviewCheckMode",
"gatePack",
Expand Down
7 changes: 4 additions & 3 deletions packages/gittensory-engine/src/types/manifest-deps-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,10 @@ export type RepositorySettings = {
publicSignalLevel: "minimal" | "standard";
checkRunMode: "off" | "enabled";
checkRunDetailLevel: "minimal" | "standard";
/** @deprecated (#4618, tracked for removal in #5373) computed read-back of {@link reviewCheckMode}
* below, kept only for API/dashboard back-compat display -- read `reviewCheckMode` instead. */
gateCheckMode: "off" | "enabled";
/** @deprecated (#4618, being removed per #5373) computed read-back of {@link reviewCheckMode} below,
* kept only for API/dashboard back-compat display -- read `reviewCheckMode` instead. Optional (widened
* ahead of full removal) so callers building a partial RepositorySettings no longer need to supply it. */
gateCheckMode?: "off" | "enabled" | undefined;
/** Scheduled re-gate sweep candidate ordering (#3815). `staleness` (default) picks whichever open PR the
* sweep has gone longest WITHOUT re-gating (see selectRegateCandidates), which is what gives the sweep its
* documented full-coverage-in-ceil(open/max)-ticks convergence guarantee even under dry-run/pause (when
Expand Down
1 change: 0 additions & 1 deletion src/github/backfill.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1168,7 +1168,6 @@ function summarizeRepairSettings(settings: RepositorySettings) {
commentMode: settings.commentMode,
publicAudienceMode: settings.publicAudienceMode,
checkRunMode: settings.checkRunMode,
gateCheckMode: settings.gateCheckMode,
reviewCheckMode: settings.reviewCheckMode,
autoLabelEnabled: settings.autoLabelEnabled,
};
Expand Down
8 changes: 4 additions & 4 deletions src/openapi/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ export const RepositorySettingsSchema = z
checkRunDetailLevel: z.enum(["minimal", "standard"]),
// @deprecated (#4618, tracked for removal in #5373): computed read-back of reviewCheckMode kept only
// for API/dashboard back-compat display -- read reviewCheckMode instead.
gateCheckMode: z.enum(["off", "enabled"]),
gateCheckMode: z.enum(["off", "enabled"]).optional(),
regateSweepOrderMode: z.enum(["staleness", "oldest-first"]),
reviewCheckMode: z.enum(["required", "visible", "disabled"]),
autoProjectMilestoneMatch: z.enum(["off", "suggest", "auto"]).optional(),
Expand Down Expand Up @@ -889,7 +889,7 @@ export const RepoSettingsPreviewSchema = z
checkRunDetailLevel: z.enum(["minimal", "standard"]),
// @deprecated (#4618, tracked for removal in #5373): computed read-back of reviewCheckMode kept only
// for API/dashboard back-compat display -- read reviewCheckMode instead.
gateCheckMode: z.enum(["off", "enabled"]),
gateCheckMode: z.enum(["off", "enabled"]).optional(),
regateSweepOrderMode: z.enum(["staleness", "oldest-first"]),
reviewCheckMode: z.enum(["required", "visible", "disabled"]),
autoProjectMilestoneMatch: z.enum(["off", "suggest", "auto"]).optional(),
Expand Down Expand Up @@ -1294,7 +1294,7 @@ export const InstallationRepairSchema = z
checkRunMode: z.enum(["off", "enabled"]),
// @deprecated (#4618, tracked for removal in #5373): computed read-back of reviewCheckMode kept only
// for API/dashboard back-compat display -- read reviewCheckMode instead.
gateCheckMode: z.enum(["off", "enabled"]),
gateCheckMode: z.enum(["off", "enabled"]).optional(),
reviewCheckMode: z.enum(["required", "visible", "disabled"]),
autoProjectMilestoneMatch: z.enum(["off", "suggest", "auto"]).optional(),
autoProjectMilestoneMatchBackend: z.enum(["github", "linear"]).optional(),
Expand Down Expand Up @@ -2215,7 +2215,7 @@ export const RegistrationReadinessSchema = z
checkRunMode: z.enum(["off", "enabled"]),
// @deprecated (#4618, tracked for removal in #5373): computed read-back of reviewCheckMode kept only
// for API/dashboard back-compat display -- read reviewCheckMode instead.
gateCheckMode: z.enum(["off", "enabled"]),
gateCheckMode: z.enum(["off", "enabled"]).optional(),
reviewCheckMode: z.enum(["required", "visible", "disabled"]),
autoProjectMilestoneMatch: z.enum(["off", "suggest", "auto"]).optional(),
autoProjectMilestoneMatchBackend: z.enum(["github", "linear"]).optional(),
Expand Down
4 changes: 0 additions & 4 deletions src/queue/processors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8006,7 +8006,6 @@ async function maybePublishPrPublicSurface(
metadata: {
deliveryId: webhook.deliveryId,
repoFullName,
gateCheckMode: settings.gateCheckMode,
reviewCheckMode: settings.reviewCheckMode,
publishedOutputs,
failedOutputs,
Expand Down Expand Up @@ -8034,7 +8033,6 @@ async function maybePublishPrPublicSurface(
publicSurface: settings.publicSurface,
label: decision.willLabel ? settings.gittensorLabel : null,
checkRunMode: settings.checkRunMode,
gateCheckMode: settings.gateCheckMode,
reviewCheckMode: settings.reviewCheckMode,
publicAudienceMode: settings.publicAudienceMode,
publishedOutputs,
Expand Down Expand Up @@ -8084,7 +8082,6 @@ async function maybePublishPrPublicSurface(
publicSurface: settings.publicSurface,
label: decision.willLabel ? settings.gittensorLabel : null,
checkRunMode: settings.checkRunMode,
gateCheckMode: settings.gateCheckMode,
reviewCheckMode: settings.reviewCheckMode,
publicAudienceMode: settings.publicAudienceMode,
publishedOutputs,
Expand All @@ -8103,7 +8100,6 @@ async function maybePublishPrPublicSurface(
publicSurface: settings.publicSurface,
labelApplied: decision.willLabel,
checkRunMode: settings.checkRunMode,
gateCheckMode: settings.gateCheckMode,
reviewCheckMode: settings.reviewCheckMode,
publicAudienceMode: settings.publicAudienceMode,
publishedOutputs,
Expand Down
8 changes: 5 additions & 3 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,11 +715,13 @@ export type RepositorySettings = {
// #4620: "deep" removed -- it was never wired to any different behavior than "standard" (formatCheckRunOutput
// and buildCheckRunAnnotations in rules/advisory.ts both branch only on `=== "minimal"` vs not).
checkRunDetailLevel: "minimal" | "standard";
/** @deprecated (#4618, tracked for removal in #5373) Legacy shadow of {@link reviewCheckMode} (#2852): a
/** @deprecated (#4618, being removed per #5373) Legacy shadow of {@link reviewCheckMode} (#2852): a
* computed read-back value only, for API/dashboard back-compat display. `"enabled"` when
* `reviewCheckMode !== "disabled"`, else `"off"` -- see getRepositorySettings/upsertRepositorySettings in
* db/repositories.ts. No write path accepts this field anymore; set {@link reviewCheckMode} directly instead. */
gateCheckMode: "off" | "enabled";
* db/repositories.ts. No write path accepts this field anymore; set {@link reviewCheckMode} directly
* instead. Optional (widened ahead of full removal) so callers building a partial RepositorySettings no
* longer need to supply it; production code (repositories.ts) still always populates it on every read. */
gateCheckMode?: "off" | "enabled" | undefined;
/** Scheduled re-gate sweep candidate ordering (#3815). `staleness` (default) picks whichever open PR the
* sweep has gone longest WITHOUT re-gating (see selectRegateCandidates), which is what gives the sweep its
* documented full-coverage-in-ceil(open/max)-ticks convergence guarantee even under dry-run/pause (when
Expand Down
Loading