Skip to content

chore(types): mark gateCheckMode @deprecated at every declaration site #5430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 12, 2026
Merged

chore(types): mark gateCheckMode @deprecated at every declaration site #5430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/gittensory-ui/src/components/site/app-panels/activation-preview.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ describe("ActivationPreview", () => {
ok: true,
data: {
repoFullName: "acme/widgets",
gateCheckMode: "enabled",
reviewCheckMode: "required",
checkRunMode: "enabled",
linkedIssueGateMode: "advisory",
Expand Down
1 change: 0 additions & 1 deletion apps/gittensory-ui/src/components/site/app-panels/activation-preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ type ActivationPreviewResponse = {

type ActivationResponse = {
repoFullName: string;
gateCheckMode: string;
reviewCheckMode: string;
checkRunMode: string;
linkedIssueGateMode: string;
Expand Down
2 changes: 2 additions & 0 deletions packages/gittensory-engine/src/types/manifest-deps-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ export type RepositorySettings = {
publicSignalLevel: "minimal" | "standard";
checkRunMode: "off" | "enabled";
checkRunDetailLevel: "minimal" | "standard";
/** @deprecated (#4618, tracked for removal in #5373) computed read-back of {@link reviewCheckMode}
* below, kept only for API/dashboard back-compat display -- read `reviewCheckMode` instead. */
gateCheckMode: "off" | "enabled";
/** Scheduled re-gate sweep candidate ordering (#3815). `staleness` (default) picks whichever open PR the
* sweep has gone longest WITHOUT re-gating (see selectRegateCandidates), which is what gives the sweep its
Expand Down
8 changes: 8 additions & 0 deletions src/openapi/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,8 @@ export const RepositorySettingsSchema = z
publicSignalLevel: z.enum(["minimal", "standard"]),
checkRunMode: z.enum(["off", "enabled"]),
checkRunDetailLevel: z.enum(["minimal", "standard"]),
// @deprecated (#4618, tracked for removal in #5373): computed read-back of reviewCheckMode kept only
// for API/dashboard back-compat display -- read reviewCheckMode instead.
gateCheckMode: z.enum(["off", "enabled"]),
regateSweepOrderMode: z.enum(["staleness", "oldest-first"]),
reviewCheckMode: z.enum(["required", "visible", "disabled"]),
Expand Down Expand Up @@ -885,6 +887,8 @@ export const RepoSettingsPreviewSchema = z
publicSignalLevel: z.enum(["minimal", "standard"]),
checkRunMode: z.enum(["off", "enabled"]),
checkRunDetailLevel: z.enum(["minimal", "standard"]),
// @deprecated (#4618, tracked for removal in #5373): computed read-back of reviewCheckMode kept only
// for API/dashboard back-compat display -- read reviewCheckMode instead.
gateCheckMode: z.enum(["off", "enabled"]),
regateSweepOrderMode: z.enum(["staleness", "oldest-first"]),
reviewCheckMode: z.enum(["required", "visible", "disabled"]),
Expand Down Expand Up @@ -1288,6 +1292,8 @@ export const InstallationRepairSchema = z
commentMode: z.enum(["off", "detected_contributors_only", "all_prs"]),
publicAudienceMode: z.enum(["oss_maintainer", "gittensor_only"]),
checkRunMode: z.enum(["off", "enabled"]),
// @deprecated (#4618, tracked for removal in #5373): computed read-back of reviewCheckMode kept only
// for API/dashboard back-compat display -- read reviewCheckMode instead.
gateCheckMode: z.enum(["off", "enabled"]),
reviewCheckMode: z.enum(["required", "visible", "disabled"]),
autoProjectMilestoneMatch: z.enum(["off", "suggest", "auto"]).optional(),
Expand Down Expand Up @@ -2207,6 +2213,8 @@ export const RegistrationReadinessSchema = z
commentMode: z.enum(["off", "detected_contributors_only", "all_prs"]),
publicAudienceMode: z.enum(["oss_maintainer", "gittensor_only"]),
checkRunMode: z.enum(["off", "enabled"]),
// @deprecated (#4618, tracked for removal in #5373): computed read-back of reviewCheckMode kept only
// for API/dashboard back-compat display -- read reviewCheckMode instead.
gateCheckMode: z.enum(["off", "enabled"]),
reviewCheckMode: z.enum(["required", "visible", "disabled"]),
autoProjectMilestoneMatch: z.enum(["off", "suggest", "auto"]).optional(),
Expand Down
2 changes: 2 additions & 0 deletions src/services/maintainer-activation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ export type MaintainerActivationPreview = {
repoFullName: string;
generatedAt: string;
// What's on today, so the UI can show the current state next to the one-click ramp.
/** @deprecated (#4618, tracked for removal in #5373) sourced from the computed read-back
* `RepositorySettings["gateCheckMode"]` -- kept only for API/dashboard back-compat display. */
currentGateMode: RepositorySettings["gateCheckMode"];
aiReviewConfigured: boolean;
evaluatedCount: number;
Expand Down
2 changes: 2 additions & 0 deletions src/signals/registration-readiness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ export type GithubAppBehavior = {
commentMode: RepositorySettings["commentMode"];
publicAudienceMode: RepositorySettings["publicAudienceMode"];
checkRunMode: RepositorySettings["checkRunMode"];
/** @deprecated (#4618, tracked for removal in #5373) computed read-back of {@link reviewCheckMode} kept
* only for API/dashboard back-compat display -- read `reviewCheckMode` instead. */
gateCheckMode: RepositorySettings["gateCheckMode"];
reviewCheckMode: RepositorySettings["reviewCheckMode"];
quietByDefault: boolean;
Expand Down
2 changes: 2 additions & 0 deletions src/signals/settings-preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,8 @@ export type RepoSettingsPreview = {
publicSignalLevel: RepositorySettings["publicSignalLevel"];
checkRunMode: RepositorySettings["checkRunMode"];
checkRunDetailLevel: RepositorySettings["checkRunDetailLevel"];
/** @deprecated (#4618, tracked for removal in #5373) computed read-back of {@link reviewCheckMode}
* kept only for API/dashboard back-compat display -- read `reviewCheckMode` instead. */
gateCheckMode: RepositorySettings["gateCheckMode"];
regateSweepOrderMode: RepositorySettings["regateSweepOrderMode"];
reviewCheckMode: RepositorySettings["reviewCheckMode"];
Expand Down
8 changes: 4 additions & 4 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,10 +715,10 @@ export type RepositorySettings = {
// #4620: "deep" removed -- it was never wired to any different behavior than "standard" (formatCheckRunOutput
// and buildCheckRunAnnotations in rules/advisory.ts both branch only on `=== "minimal"` vs not).
checkRunDetailLevel: "minimal" | "standard";
/** Legacy shadow of {@link reviewCheckMode} (#2852), deprecated (#4618): a computed read-back value only,
* for API/dashboard back-compat display. `"enabled"` when `reviewCheckMode !== "disabled"`, else `"off"`
* -- see getRepositorySettings/upsertRepositorySettings in db/repositories.ts. No write path accepts this
* field anymore; set {@link reviewCheckMode} directly instead. */
/** @deprecated (#4618, tracked for removal in #5373) Legacy shadow of {@link reviewCheckMode} (#2852): a
* computed read-back value only, for API/dashboard back-compat display. `"enabled"` when
* `reviewCheckMode !== "disabled"`, else `"off"` -- see getRepositorySettings/upsertRepositorySettings in
* db/repositories.ts. No write path accepts this field anymore; set {@link reviewCheckMode} directly instead. */
gateCheckMode: "off" | "enabled";
/** Scheduled re-gate sweep candidate ordering (#3815). `staleness` (default) picks whichever open PR the
* sweep has gone longest WITHOUT re-gating (see selectRegateCandidates), which is what gives the sweep its
Expand Down
Loading