Skip to content

fix(miner): add three lib files missing from build:miner's check list - #5210

Merged
JSONbored merged 1 commit into
mainfrom
fix/miner-build-checklist-gap
Jul 12, 2026
Merged

fix(miner): add three lib files missing from build:miner's check list#5210
JSONbored merged 1 commit into
mainfrom
fix/miner-build-checklist-gap

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

Scope

  • The PR title follows type(scope): short summary Conventional Commit format.
  • This PR is focused (one line, one file) and does not mix unrelated changes.
  • Maintainer-only, self-contained bugfix — no linked issue needed.

Validation

  • npm run typecheck
  • npm run build:miner — confirmed all three files are now checked
  • npm run test:miner-pack
  • npm audit --audit-level=moderate

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 12, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui b0df3a0 Commit Preview URL

Branch Preview URL
Jul 12 2026, 09:42 AM

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 12, 2026
@loopover-orb

loopover-orb Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-12 09:40:08 UTC

1 file · 1 AI reviewer · 1 blocker · readiness 100/100 · CI green · dirty

⏸️ Suggested Action - Manual Review

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

Review summary
Adds the three missing `node --check` entries (attempt-cli.js, execute-local-write.js, live-issue-snapshot.js) to build:miner's hand-maintained file list, matching the stated intent and the description's claim that these files were added in a prior PR but never syntax-checked by this script. The change is a single-line, purely additive edit to the `&&`-joined command string, alphabetically ordered consistent with the existing entries, and carries no logic risk.

Nits — 4 non-blocking
  • The build script's file list is hand-maintained and will keep drifting from the actual lib/ directory contents; consider generating it via a glob (e.g. `for f in lib/*.js; do node --check "$f"; done`) to prevent this class of bug recurring, as the PR description itself notes happened again in Persist governor cross-attempt state (rate-limit, budget, convergence, reputation, self-plagiarism) #5134.
  • packages/gittensory-miner/package.json: replace the long hand-maintained `&&` chain with a small shell loop or Node script that globs lib/*.js, so new files are automatically covered by build:miner without manual edits.
  • nit: `packages/gittensory-miner/package.json:33` keeps syntax-check coverage as a long hand-maintained command, so the same omission can recur when future `lib/*.js` files are added.
  • Consider replacing the explicit `node --check ... && node --check ...` chain in `packages/gittensory-miner/package.json:33` with a small script that enumerates `bin/**/*.js` and `lib/**/*.js`, or add a parity test that fails when a shipped JS file is not included in `build`.

Concerns raised — review before merging

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Signal Result Evidence
Code review ❌ 1 blocker 1 reviewer
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 45 registered-repo PR(s), 37 merged, 409 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 45 PR(s), 409 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Improvement ⚠️ ℹ️ Insufficient signal risk: clean · value: insufficient-signal — Nothing measurable for the structural-improvement analyzers on this PR (e.g. no code files changed).
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 45 PR(s), 409 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 12, 2026
write.js, and live-issue-snapshot.js but missed the corresponding
entries in packages/gittensory-miner/package.json's build script,
whose node --check file list is hand-maintained rather than
generated from the directory -- so their syntax was never actually
verified by build:miner despite test:miner-pack (directory-globbed)
already including them.
@JSONbored
JSONbored force-pushed the fix/miner-build-checklist-gap branch from 36bfd33 to b0df3a0 Compare July 12, 2026 09:41
@JSONbored
JSONbored merged commit b81e00c into main Jul 12, 2026
12 checks passed
@JSONbored
JSONbored deleted the fix/miner-build-checklist-gap branch July 12, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant