fix(miner): add three lib files missing from build:miner's check list - #5210
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | b0df3a0 | Commit Preview URL Branch Preview URL |
Jul 12 2026, 09:42 AM |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-12 09:40:08 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 4 non-blocking
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
write.js, and live-issue-snapshot.js but missed the corresponding entries in packages/gittensory-miner/package.json's build script, whose node --check file list is hand-maintained rather than generated from the directory -- so their syntax was never actually verified by build:miner despite test:miner-pack (directory-globbed) already including them.
36bfd33 to
b0df3a0
Compare
Summary
attempt-cli.js,execute-local-write.js, andlive-issue-snapshot.jsbut missed the corresponding entries inpackages/gittensory-miner/package.json'sbuildscript, whosenode --checkfile list is hand-maintained rather than generated from the directory — so their syntax was never actually verified bybuild:miner, despitetest:miner-pack(directory-globbed) already including them in its package manifest.Scope
type(scope): short summaryConventional Commit format.Validation
npm run typechecknpm run build:miner— confirmed all three files are now checkednpm run test:miner-packnpm audit --audit-level=moderate