Skip to content

ci: run UI validation for packages/gittensory-ui-kit changes - #5150

Merged
JSONbored merged 1 commit into
mainfrom
codex/fix-ci-validation-bypass-for-ui-kit
Jul 12, 2026
Merged

ci: run UI validation for packages/gittensory-ui-kit changes#5150
JSONbored merged 1 commit into
mainfrom
codex/fix-ci-validation-bypass-for-ui-kit

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • Ensure changes to the shared UI package run the full UI validation (lint/typecheck/test/build) because the UI apps now depend on @jsonbored/gittensory-ui-kit.

Description

  • Add packages/gittensory-ui-kit/** to the ui filter in .github/workflows/ci.yml so UI-kit-only PRs set needs.changes.outputs.ui and trigger the UI build/lint/typecheck/test steps.

Testing

  • Ran git diff --check, which passed.
  • Ran npm run actionlint, which passed (used the WASM fallback when actionlint setup retried due to DNS issues).
  • Attempted npm run test:ci, which did not reach the UI checks because npm run cf-typegen:check reported existing worker-configuration.d.ts drift unrelated to this change.
  • Attempted npm audit --audit-level=moderate, which was blocked by the npm registry audit endpoint returning 403 Forbidden in this environment.

Codex Task

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.13%. Comparing base (3213313) to head (74d1acd).
⚠️ Report is 59 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5150   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files         465      465           
  Lines       39554    39554           
  Branches    14433    14433           
=======================================
  Hits        37235    37235           
  Misses       1664     1664           
  Partials      655      655           
Flag Coverage Δ
shard-1 46.50% <ø> (ø)
shard-2 33.56% <ø> (+<0.01%) ⬆️
shard-3 31.33% <ø> (ø)
shard-4 32.68% <ø> (ø)
shard-5 33.43% <ø> (ø)
shard-6 44.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 12, 2026
@loopover-orb

loopover-orb Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-12 09:01:39 UTC

1 file · 1 AI reviewer · 2 blockers · readiness 93/100 · CI green · unstable

⏸️ Suggested Action - Manual Review

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Review summary
This is a one-line CI workflow change that adds `packages/gittensory-ui-kit/**` to the `ui` filter path list in `.github/workflows/ci.yml`, ensuring changes to the shared UI-kit package trigger the UI lint/typecheck/test/build steps in CI. The change is correct and minimal: the filter list already had similar path entries for `apps/gittensory-ui/**` etc., and this follows the same pattern. Given that `apps/gittensory-ui` and `apps/gittensory-miner-ui` depend on `@​jsonbored/gittensory-ui-kit` (confirmed by the `ui:kit:build` step preceding UI lint/typecheck/test in package.json), this closes a real gap where UI-kit-only PRs could bypass UI validation.

Blockers

Nits — 3 non-blocking
  • Confirm the `ui` filter's YAML anchor/list ordering doesn't matter for path-filter matching (it typically doesn't), so placement of the new line between `apps/gittensory-extension/**` and `scripts/build-extension.mjs` is purely cosmetic.
  • No further changes needed; this is a narrow, well-targeted CI filter fix.
  • .github/workflows/ci.yml:75: Keep this path grouped with the UI app paths as you did; that is the right filter layer for ensuring `needs.changes.outputs.ui` is set for UI-kit-only PRs.

Concerns raised — review before merging

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.
Signal Result Evidence
Code review ❌ 2 blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 45 registered-repo PR(s), 37 merged, 409 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 45 PR(s), 409 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Improvement ⚠️ ℹ️ Insufficient signal risk: clean · value: insufficient-signal — Nothing measurable for the structural-improvement analyzers on this PR (e.g. no code files changed).
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 45 PR(s), 409 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 12, 2026
@JSONbored
JSONbored merged commit b647bec into main Jul 12, 2026
18 checks passed
@JSONbored
JSONbored deleted the codex/fix-ci-validation-bypass-for-ui-kit branch July 12, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant