Skip to content

fix(selfhost): retry the /ready probe in selfhost-post-update-check.sh instead of a single attempt #5086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 11, 2026
Merged

fix(selfhost): retry the /ready probe in selfhost-post-update-check.sh instead of a single attempt #5086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions scripts/selfhost-post-update-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,24 @@ if [ -z "$container_id" ]; then
exit 1
fi

# Retry, don't single-probe: `docker compose up -d` returns as soon as the container STARTS, well before
# the app inside has bound its port -- a single immediate curl reliably false-fails on a normal boot. Budget
# matches the gittensory service's own Docker healthcheck start_period (60s, docker-compose.yml) plus margin,
# polling often enough that a normal ~15-20s boot returns almost immediately once actually ready.
READY_RETRIES="${SELFHOST_READY_RETRIES:-45}"
READY_RETRY_DELAY_SECONDS="${SELFHOST_READY_RETRY_DELAY_SECONDS:-2}"

echo "selfhost post-update check: probing $READY_URL"
if ! curl -sf "$READY_URL" >/dev/null; then
echo "error: $READY_URL did not return HTTP 2xx" >&2
ready=0
for _ in $(seq 1 "$READY_RETRIES"); do
if curl -sf "$READY_URL" >/dev/null; then
ready=1
break
fi
sleep "$READY_RETRY_DELAY_SECONDS"
done
if [ "$ready" -ne 1 ]; then
echo "error: $READY_URL did not return HTTP 2xx after $READY_RETRIES attempts ($((READY_RETRIES * READY_RETRY_DELAY_SECONDS))s)" >&2
exit 1
fi

Expand Down