fix(release): allow an empty commit when cutting the ORB stable Release PR - #5067
Merged
Conversation
…se PR orb-manifest.json's version can already equal the proposed nextVersion (the common case right after a maintainer hand-bumps it ahead of landing the commits that warrant it) -- confirmed live on the first real run: orb-manifest.json already said 0.4.0, the script also proposed 0.4.0, so git add staged nothing and git commit failed outright, never reaching the push/PR-create steps. --allow-empty makes the branch/PR always get created as the reviewable release marker regardless.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5067 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 465 465
Lines 39554 39554
Branches 14433 14433
=======================================
Hits 37235 37235
Misses 1664 1664
Partials 655 655
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orb-stable-release-prrun:orb-manifest.jsonalready declared"0.4.0", andbuildOrbStableReleaseReport's inferred next version was also0.4.0(the common case right after a maintainer hand-bumps the manifest ahead of landing the commits that warrant it) -- so writing the "proposed" version produced a byte-identical file,git addstaged nothing, andgit commitfailed outright before the push/PR-create steps ever ran.git commit --allow-empty-- the branch/PR is the reviewable release marker regardless of whether the manifest content actually changes.orb-stable-release-pr.ymlagainst this fix branch directly (workflow_dispatchwith--ref) and it succeeded, correctly opening chore(release): cut orb-v0.4.0 #5066 (chore(release): cut orb-v0.4.0) with the full commit list sinceorb-v0.3.0in the body.Maintainer PR (JSONbored) -- no linked issue per the repo's maintainer exception.
Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typecheckworkflow_dispatch --refon this branch, confirmed it now succeeds and opens a correct Release PR (chore(release): cut orb-v0.4.0 #5066).npm audit --audit-level=moderate-- 0 vulnerabilities (no dependency changes).Safety
Notes
UI Evidencesection.