test(miner-governor): close branch-coverage gaps in self-review adapter tests

[JSONbored]

Summary

Follow-up to #2334 (#5034, merged). Real coverage measurement via node --experimental-test-coverage (not just visual test-suite review) found self-review-adapter.js at only 50% branch coverage despite the existing suite looking thorough on read-through:

• buildSelfReviewPredictedGateInput's four optional-field conditional spreads (body, labels, linkedIssues, authorAssociation) each only had one side of their ternary exercised (the tests always used a diff state that set some fields and omitted others, but never varied it across both directions for the same field).
• buildSelfReviewSlopInput's (diffState.linkedIssues?.length ?? 0) > 0 fallback chain was only exercised with linkedIssues: [], never with linkedIssues: undefined -- a distinct branch.
• runSelfReview's three optional context-field spreads (bounties, issueQuality, confirmedContributor) were never exercised with those fields actually set.

Adds four targeted tests closing all 8 zero-hit branches identified via LCOV BRDA analysis. No production code changes -- test-only.

Validation

• npm run build && npx tsc -p tsconfig.test.json && node --experimental-test-coverage --test "dist-test/**/*.test.js" -- 400/400 tests pass.
• self-review-adapter.js coverage: 100.00% lines / 100.00% branch / 100.00% funcs (was 50% branch before this PR).

Test plan

• All engine node:test tests pass (400/400).
• Measured branch coverage on the touched file is 100%.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	gittensory-ui	abaf95f	Commit Preview URL Branch Preview URL	Jul 11 2026, 09:51 AM

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-11 09:53:52 UTC}

1 file · 1 AI reviewer · 1 blocker · readiness 100/100 · CI green · unstable

⏸️ Suggested Action - Manual Review

• No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

Review summary
This is a test-only PR that closes 8 previously zero-hit branches in self-review-adapter.js's test suite (optional-field ternaries in buildSelfReviewPredictedGateInput, the linkedIssues `?.length ?? 0` fallback in buildSelfReviewSlopInput, and optional context-field forwarding in runSelfReview). Each new test exercises a genuinely distinct, real branch — e.g. `linkedIssues: undefined` vs `linkedIssues: []` are different inputs to the same nullish-fallback expression, and the labels/authorAssociation test exercises the 'field present' side of conditional spreads that prior tests only exercised from the 'absent' side. No production code changes, and the new assertions cross-check against direct `buildPredictedGateVerdict` calls the same way the existing suite already does, so this follows established convention rather than inventing a new pattern.

Nits — 4 non-blocking

• The PR description ties this to 'maintainer: self-review adapter wiring iterate-loop diffs through predicted-gate + slop scoring #2334 (feat(miner-governor): self-review adapter wiring diffs through predicted-gate + slop (#2334) #5034, merged)' but doesn't cite a currently-open issue this PR itself closes — worth confirming there's still an open, eligible issue this closes, or noting explicitly that it's a direct coverage follow-up sanctioned by the maintainer.
• packages/gittensory-engine/test/self-review-adapter.test.ts: the new inline comments (e.g. explaining the `?.length ?? 0` distinction) are helpful but slightly verbose relative to the terser comments elsewhere in the file — not worth blocking on.
• Confirm in the PR body which issue (if any distinct from maintainer: self-review adapter wiring iterate-loop diffs through predicted-gate + slop scoring #2334) this specifically closes, per the repo's issue-linking requirement for contributor PRs.
• Consider a one-line coverage note in the PR body citing the exact LCOV BRDA lines closed, matching the specificity already used for the branch descriptions, so reviewers can spot-check them directly.

Concerns raised — review before merging

• No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

Signal	Result	Evidence
Code review	❌ 1 blocker	1 reviewer
Linked issue	✅ No-issue rationale	PR body explains why no issue is linked.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 47 registered-repo PR(s), 39 merged, 428 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 47 PR(s), 428 issue(s).
Gate result	❌ Blocking	Repo-configured hard blocker found.
Improvement	⚠️ ℹ️ Insufficient signal	risk: clean · value: insufficient-signal — Nothing measurable for the structural-improvement analyzers on this PR (e.g. no code files changed). LLM value judgment: moderate — It closes 8 real, previously-unhit branches in a hot-path self-review adapter with tests that exercise genuinely distinct inputs rather than fabricating unreachable states, meaningfully raising confidence in a file central to gate-prediction correctness.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 47 PR(s), 428 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review