fix(github-app): preserve gate checks when public output is skipped - #485
Merged
Merged
Conversation
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | ce310f1 | Commit Preview URL Branch Preview URL |
Jun 10 2026, 06:08 AM |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
This was referenced Jun 9, 2026
This was referenced Jun 10, 2026
JSONbored
force-pushed
the
codex/propose-fix-for-pr-gate-check-bypass
branch
from
June 10, 2026 06:06
e94702d to
ce310f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
publicSurfaceSkippedflag inmaybePublishPrPublicSurfaceto record visibility skips without exiting the whole processor whengateEnabledis true. (modifiessrc/queue/processors.ts).gateEnabledis true even if public output is suppressed, and only avoid publishing public outputs. (adjusted pending/final gate check path andprelimHasPublicOutputlogic).test/unit/queue.test.ts).Testing
npm run typecheck, which succeeded after fixes to nullable author handling. (passed)npx vitest run test/unit/queue.test.ts, and all unit tests passed. (52 passed)npx vitest run test/unit/queue.test.ts --testNamePattern "publishes an enabled gate|publishes an opt-in gate"to validate the new regressions, and the targeted tests passed. (passed)Codex Task