Skip to content

fix(github-app): preserve gate checks when public output is skipped - #485

Merged
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-pr-gate-check-bypass
Jun 10, 2026
Merged

fix(github-app): preserve gate checks when public output is skipped#485
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-pr-gate-check-bypass

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • Public-surface skip logic returned from the processor before any Gittensory Gate check was created or updated, which suppressed configured hard blockers for PRs when public output would be skipped (bot authors, miner detection failures, etc.).

Description

  • Introduce a publicSurfaceSkipped flag in maybePublishPrPublicSurface to record visibility skips without exiting the whole processor when gateEnabled is true. (modifies src/queue/processors.ts).
  • Continue to create pending and final gate check runs when gateEnabled is true even if public output is suppressed, and only avoid publishing public outputs. (adjusted pending/final gate check path and prelimHasPublicOutput logic).
  • Treat Gittensor-only miner-detection failures as public-output skips when gate checks are enabled, so gate evaluation still runs while public comment/label/check-run outputs remain suppressed.
  • Add regression tests verifying that enabled gate checks are still published for (1) bot-author public-surface skips and (2) unconfirmed-miner Gittensor-only public-surface skips. (adds tests in test/unit/queue.test.ts).

Testing

  • Ran TypeScript typecheck with npm run typecheck, which succeeded after fixes to nullable author handling. (passed)
  • Ran unit tests with npx vitest run test/unit/queue.test.ts, and all unit tests passed. (52 passed)
  • Ran a focused test run npx vitest run test/unit/queue.test.ts --testNamePattern "publishes an enabled gate|publishes an opt-in gate" to validate the new regressions, and the targeted tests passed. (passed)

Codex Task

@ghost

ghost commented Jun 9, 2026

Copy link
Copy Markdown

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #485 is no longer open. No action.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost added the gittensory:reviewed label Jun 9, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui ce310f1 Commit Preview URL

Branch Preview URL
Jun 10 2026, 06:08 AM

@superagent-security

superagent-security Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored changed the title Preserve gate checks when public-surface visibility is skipped fix(github-app): preserve gate checks when public output is skipped Jun 10, 2026
@JSONbored
JSONbored force-pushed the codex/propose-fix-for-pr-gate-check-bypass branch from e94702d to ce310f1 Compare June 10, 2026 06:06
@github-actions github-actions Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 10, 2026
@JSONbored
JSONbored merged commit f624dd4 into main Jun 10, 2026
10 checks passed
@JSONbored
JSONbored deleted the codex/propose-fix-for-pr-gate-check-bypass branch June 10, 2026 06:09
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant