chore(config): remove unused review.labeling_rules field - #4819
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 0e3eeb7 | Commit Preview URL Branch Preview URL |
Jul 11 2026, 01:06 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4819 +/- ##
==========================================
- Coverage 94.23% 94.23% -0.01%
==========================================
Files 442 442
Lines 38845 38807 -38
Branches 14150 14134 -16
==========================================
- Hits 36607 36570 -37
Misses 1577 1577
+ Partials 661 660 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The deterministic label-suggestion parser (review.labeling_rules, #2045) was fully parsed and validated but never wired to any label application path, so it was dead config. Removed the field, its type, and the parser/serializer support from the engine package, along with the corresponding docs and tests. Closes #4146
948e249 to
0e3eeb7
Compare
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review result - approve/merge recommendedReview updated: 2026-07-11 01:18:37 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 4 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
review.labeling_rules(feat(config): add review.labeling_rules deterministic label suggestions #2045) was fully parsed, validated, and serialized but never wired to any label-application code path — it was pure dead config.LabelingRuletype, thelabelingRulesfield,parseReviewLabelingRules,RESERVED_LABEL_PREFIX, and thereviewConfigToJsonserialization block frompackages/gittensory-engine/src/focus-manifest.ts.LabelingRulere-export from the engine package'sindex.tsand fromsrc/signals/focus-manifest.ts's shim.labeling_rulesdocumentation blocks from.gittensory.yml.exampleandconfig/examples/gittensory.full.yml(kept byte-identical from the# WHERE IT LIVESmarker onward), and updates the two prose mentions inconfig/examples/README.mdto a still-existing example field.test/unit/focus-manifest-engine-branch-coverage.test.tsand thelabelingRulesfixture properties intest/unit/focus-manifest.test.ts/test/unit/signals-coverage.test.ts.Closes #4146
Test plan
npx tsc --noEmit -p .— zero errorsnpx vitest run test/unit test/integration— 689 files passed (1 skipped), 13771 tests passednpm run test:coverage(unsharded) — 94.43% statements / 93.4% branches / 93.59% functions / 95.02% lines, no threshold failuresnpm run docs:drift-check,npm run manifest:drift-check,npm run engine-parity:drift-check— all oknpm audit --audit-level=moderate— 0 vulnerabilities