Skip to content

chore(config): remove unused review.labeling_rules field - #4819

Merged
JSONbored merged 1 commit into
mainfrom
chore/4146-remove-labeling-rules
Jul 11, 2026
Merged

chore(config): remove unused review.labeling_rules field#4819
JSONbored merged 1 commit into
mainfrom
chore/4146-remove-labeling-rules

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • review.labeling_rules (feat(config): add review.labeling_rules deterministic label suggestions #2045) was fully parsed, validated, and serialized but never wired to any label-application code path — it was pure dead config.
  • Removes the LabelingRule type, the labelingRules field, parseReviewLabelingRules, RESERVED_LABEL_PREFIX, and the reviewConfigToJson serialization block from packages/gittensory-engine/src/focus-manifest.ts.
  • Removes the LabelingRule re-export from the engine package's index.ts and from src/signals/focus-manifest.ts's shim.
  • Drops the labeling_rules documentation blocks from .gittensory.yml.example and config/examples/gittensory.full.yml (kept byte-identical from the # WHERE IT LIVES marker onward), and updates the two prose mentions in config/examples/README.md to a still-existing example field.
  • Removes the now-obsolete parser tests in test/unit/focus-manifest-engine-branch-coverage.test.ts and the labelingRules fixture properties in test/unit/focus-manifest.test.ts / test/unit/signals-coverage.test.ts.

Closes #4146

Test plan

  • npx tsc --noEmit -p . — zero errors
  • npx vitest run test/unit test/integration — 689 files passed (1 skipped), 13771 tests passed
  • npm run test:coverage (unsharded) — 94.43% statements / 93.4% branches / 93.59% functions / 95.02% lines, no threshold failures
  • npm run docs:drift-check, npm run manifest:drift-check, npm run engine-parity:drift-check — all ok
  • npm audit --audit-level=moderate — 0 vulnerabilities

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 11, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 0e3eeb7 Commit Preview URL

Branch Preview URL
Jul 11 2026, 01:06 AM

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.23%. Comparing base (20c412b) to head (0e3eeb7).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4819      +/-   ##
==========================================
- Coverage   94.23%   94.23%   -0.01%     
==========================================
  Files         442      442              
  Lines       38845    38807      -38     
  Branches    14150    14134      -16     
==========================================
- Hits        36607    36570      -37     
  Misses       1577     1577              
+ Partials      661      660       -1     
Flag Coverage Δ
shard-1 51.60% <100.00%> (+0.11%) ⬆️
shard-2 45.35% <100.00%> (-0.06%) ⬇️
shard-3 41.99% <100.00%> (+0.03%) ⬆️
shard-4 51.95% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/gittensory-engine/src/focus-manifest.ts 99.17% <100.00%> (+0.06%) ⬆️
src/signals/focus-manifest.ts 99.64% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The deterministic label-suggestion parser (review.labeling_rules,
#2045) was fully parsed and validated but never wired to any label
application path, so it was dead config. Removed the field, its
type, and the parser/serializer support from the engine package,
along with the corresponding docs and tests.

Closes #4146
@JSONbored
JSONbored force-pushed the chore/4146-remove-labeling-rules branch from 948e249 to 0e3eeb7 Compare July 11, 2026 01:04
@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 11, 2026
@loopover-orb

loopover-orb Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review result - approve/merge recommended

Review updated: 2026-07-11 01:18:37 UTC

9 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a clean, well-scoped dead-code removal: `labeling_rules`/`LabelingRule` was fully parsed and serialized but never wired to any label-application code path, and this PR removes it symmetrically across the type, parser, `EMPTY_MANIFEST`/`emptyManifest` literals, `computeReviewConfigPresent`, `overlayReviewConfig`, `reviewConfigToJson`, both public re-exports, the two example YAML files, and the corresponding tests. Issue #4146 explicitly offered 'wire it up, or remove the dead config field' as the two acceptable resolutions, so removal closes it validly. I traced each removal site and found no dangling reference left behind (all four `labelingRules:`/`labeling_rules` occurrences in the object literals, parser, overlay, and serializer are removed together), and the fixture/test updates in `focus-manifest.test.ts` and `signals-coverage.test.ts` match the field removal exactly.

Nits — 4 non-blocking
  • `config/examples/README.md:45,144` swaps the `labeling_rules` example mention for `exclude_paths` — reasonable, but worth double-checking `exclude_paths` is actually a good illustrative example of a house-policy field an operator would centralize (vs. something like `path_filters`, which is already mentioned in the same sentence).
  • None beyond the nit above — the removal is symmetric and the diff is internally consistent.
  • PR author also opened the linked issue — Link an issue that was opened by a different contributor, or provide a rationale for why this self-authored issue represents genuine discovery work.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #4146
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 48 registered-repo PR(s), 40 merged, 275 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 48 PR(s), 275 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, TypeScript, Ruby, Go, JavaScript, MDX, Shell, Solidity
  • Official Gittensor activity: 48 PR(s), 275 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 11, 2026
@JSONbored
JSONbored merged commit cad5c91 into main Jul 11, 2026
18 checks passed
@JSONbored
JSONbored deleted the chore/4146-remove-labeling-rules branch July 11, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Development

Successfully merging this pull request may close these issues.

feat(review): wire labelingRules to a real label-suggestion evaluator, or remove the dead config field

1 participant