feat(review): decouple e2e-test-gen auto-trigger and widen checkbox auth (#4199) - #4757
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 075fcc0 | Commit Preview URL Branch Preview URL |
Jul 11 2026, 12:19 AM |
…uth (#4199) The manifest_missing_tests auto-trigger and the maintainer-initiated command/checkbox paths shared one flag (features.e2eTests), so enabling on-demand test generation for a repo also silently turned on unprompted auto-firing. Add review.e2e_test_auto_trigger (default off, per-repo) as a separate, explicit opt-in required in addition to features.e2eTests. The generate-tests checkbox also hardcoded a maintainer-only commandAuthorization override, ignoring whatever a repo's own .gittensory.yml configured -- unlike the identical text command, which already respects settings.commandAuthorization. Remove the override so the checkbox resolves the same, already-safely-clamped policy (still maintainer-only by default; widenable per repo to collaborator/ confirmed_miner, never to the spoofable raw pr_author role). Add a [BETA] badge to the checkbox label.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4757 +/- ##
=======================================
Coverage 94.22% 94.22%
=======================================
Files 441 441
Lines 38745 38748 +3
Branches 14106 14107 +1
=======================================
+ Hits 36508 36511 +3
Misses 1577 1577
Partials 660 660
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-11 00:12:31 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 1 non-blocking
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
fa5afc7 to
075fcc0
Compare
Rebasing onto main picked up #4757 (feat(review): decouple e2e-test-gen auto-trigger and widen checkbox auth), which touched the monolithic queue.test.ts before it was split. That content now lives in queue-5.test.ts, so port the same test changes there: the new autoTrigger opt-in on seedAutoTriggerPr, its three new/updated tests, and the [BETA] badge text update. Verified against main's actual source change (src/queue/processors.ts already carries the [BETA] label) and a full run of all 6 split queue files: 813 tests passing (810 + 3 new).
Rebasing onto main picked up #4757 (feat(review): decouple e2e-test-gen auto-trigger and widen checkbox auth), which touched the monolithic queue.test.ts before it was split. That content now lives in queue-5.test.ts, so port the same test changes there: the new autoTrigger opt-in on seedAutoTriggerPr, its three new/updated tests, and the [BETA] badge text update. Verified against main's actual source change (src/queue/processors.ts already carries the [BETA] label) and a full run of all 6 split queue files: 813 tests passing (810 + 3 new).
Rebasing onto main picked up #4757 (feat(review): decouple e2e-test-gen auto-trigger and widen checkbox auth), which touched the monolithic queue.test.ts before it was split. That content now lives in queue-5.test.ts, so port the same test changes there: the new autoTrigger opt-in on seedAutoTriggerPr, its three new/updated tests, and the [BETA] badge text update. Verified against main's actual source change (src/queue/processors.ts already carries the [BETA] label) and a full run of all 6 split queue files: 813 tests passing (810 + 3 new).
…es (#4814) * test(unit): split queue.test.ts and backfill.test.ts into smaller files queue.test.ts (33,461 lines / 810 tests) and backfill.test.ts (6,874 lines / 236 tests) each ran as one atomic unit under a single vitest worker -- queue.test.ts alone accounted for ~282s (roughly half the wall-clock) of the full coverage run's ~565s duration, since vitest schedules whole test files to workers and can't parallelize within one file. Split each into several files along safe, verified boundaries (no shared mutable state crosses a file boundary; hoisted helper functions used across sections were promoted into each file's shared header). Test count and pass/fail results are identical before and after (810 and 236 tests respectively, all passing) -- verified via `vitest run` on the full old-vs-new file sets. Also fixes two stale comments in src/queue/processors.ts that named the old monolithic queue.test.ts file for a test that moved. * fixup: port #4757's e2e-test-gen changes into split queue-5.test.ts Rebasing onto main picked up #4757 (feat(review): decouple e2e-test-gen auto-trigger and widen checkbox auth), which touched the monolithic queue.test.ts before it was split. That content now lives in queue-5.test.ts, so port the same test changes there: the new autoTrigger opt-in on seedAutoTriggerPr, its three new/updated tests, and the [BETA] badge text update. Verified against main's actual source change (src/queue/processors.ts already carries the [BETA] label) and a full run of all 6 split queue files: 813 tests passing (810 + 3 new). * fixup: port #4732, #4659, #4816 test changes into split queue files * fixup: port #4732 and #4816 test changes into split queue files * fixup: port latest main's queue.test.ts changes into split queue-4.test.ts
Summary
manifest_missing_testsauto-trigger and the maintainer-initiated command/checkbox paths shared one flag (features.e2eTests), so enabling on-demand test generation for a repo also silently enabled unprompted auto-firing. Addreview.e2e_test_auto_trigger(default off, per-repo) as a separate, explicit opt-in required in addition tofeatures.e2eTests.commandAuthorizationoverride, ignoring whatever a repo's own.gittensory.ymlconfigured — unlike the identical text command, which already respectssettings.commandAuthorization. Remove the override so the checkbox resolves the same, already-safely-clamped policy (still maintainer-only by default; widenable per repo tocollaborator/confirmed_miner, never to the spoofable rawpr_authorrole).[BETA]badge to the checkbox label.Advances #4199. Follow-up to #4196 and #4589 (both closed/shipped, this corrects a gap in each).
Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally (fullnpm run test:ci, unsharded) — 94.42% statements / 93.39% branches globally; every touched file at 100% line+branch within its own tests; both new gates bug-injection verified (temporarily reverted each fix and confirmed the new regression test fails, then restored and confirmed green).npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderate— 0 vulnerabilitiesSafety
pr_authorclamp still denying the PR's own author even when a repo tries to configure it..gittensory.yml/FocusManifestconfig layer, mirroringreview.e2e_test_delivery's existing precedent.Notes
gittensoryrepo's own self-host config (GITTENSORY_REVIEW_E2E_TESTSstays off on the deployed instance until this ships and a new ORB image is cut/deployed).