chore(review): remove dead checkRunDetailLevel.deep (#4620)

[JSONbored]

Summary

Follow-up to #4620's dead-config audit. checkRunDetailLevel: "deep" was never wired to any different behavior than "standard" — verified both consumers (formatCheckRunOutput and buildCheckRunAnnotations in src/rules/advisory.ts) branch only on detailLevel === "minimal" vs not, with zero code path distinguishing "standard" from "deep". A repo configured to "deep" has always rendered byte-identical check-run output to "standard".

• Removed the value from RepositorySettings["checkRunDetailLevel"], both settings-write API schemas, the yml settings.checkRunDetailLevel parser (engine package), and the maintainer dashboard's detail-level select.
• parseCheckRunDetailLevel now degrades any non-"minimal" persisted value (including a pre-existing "deep" row) to "standard" on read — no DB migration needed since the two were already behaviorally identical.
• Mirrored the type change in the UI's CheckRunDetailLevel type and its readiness-table helpers.

Test plan

• npx tsc --noEmit (root + apps/gittensory-ui) — clean
• Full unit + integration suite: 686 files / 13,644 tests passing
• npm run engine-parity:drift-check, npm run ui:openapi:check (regenerated openapi.json), npm run ui:openapi:settings-parity, npm run docs:drift-check, npm run manifest:drift-check — all pass
• npm run ui:lint (0 errors) + UI test suite + npm audit --audit-level=moderate (0 vulnerabilities)

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	gittensory-ui	391c4a0	Commit Preview URL Branch Preview URL	Jul 10 2026, 10:42 PM

[codecov]

❌ 3 Tests Failed:

Tests completed	Failed	Passed	Skipped
13713	3	13710	12

View the top 3 failed test(s) by shortest run time

test/unit/check-engine-parity-script.test.ts > check-engine-parity script > engine version skew > uses default version readers against the real monorepo workspace

Stack Traces | 0.0716s run time

AssertionError: expected [ Array(1) ] to deeply equal []

- Expected
+ Received

- []
+ [
+   "Gate-decision logic change in src/rules/advisory.ts requires either:
+   • a matching edit to the other twin (.../src/advisory/gate-advisory.ts), or
+   • a version bump in packages/gittensory-engine/package.json (currently 0.2.0 vs base 0.2.0).",
+ ]

 ❯ test/unit/check-engine-parity-script.test.ts:494:31

test/unit/check-engine-parity-script.test.ts > check-engine-parity script > runEngineParityMain returns 0 for the real monorepo workspace

Stack Traces | 0.0752s run time

AssertionError: expected 1 to be +0 // Object.is equality

- Expected
+ Received

- 0
+ 1

 ❯ test/unit/check-engine-parity-script.test.ts:507:48

test/unit/check-engine-parity-script.test.ts > check-engine-parity script > prints a clean summary and exits 0 for the real repo state when run as a subprocess

Stack Traces | 1.14s run time

Error: Command failed: .../gittensory/node_modules/.bin/tsx scripts/check-engine-parity.ts
Engine-parity check found 1 issue(s):
Gate-decision logic change in src/rules/advisory.ts requires either:
  • a matching edit to the other twin (.../src/advisory/gate-advisory.ts), or
  • a version bump in packages/gittensory-engine/package.json (currently 0.2.0 vs base 0.2.0).

 ❯ test/unit/check-engine-parity-script.test.ts:512:20

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { status: 1, signal: null, output: [ null, '', 'Engine-parity check found 1 issue(s):\nGate-decision logic change in src/rules/advisory.ts requires either:\n  • a matching edit to the other twin (.../src/advisory/gate-advisory.ts), or\n  • a version bump in packages/gittensory-engine/package.json (currently 0.2.0 vs base 0.2.0).\n' ], pid: 5390, stdout: '', stderr: 'Engine-parity check found 1 issue(s):\nGate-decision logic change in src/rules/advisory.ts requires either:\n  • a matching edit to the other twin (.../src/advisory/gate-advisory.ts), or\n  • a version bump in packages/gittensory-engine/package.json (currently 0.2.0 vs base 0.2.0).\n' }

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}