fix(ci): disambiguate orb beta release dispatch ref - #4731
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4731 +/- ##
=======================================
Coverage 94.14% 94.14%
=======================================
Files 437 437
Lines 38531 38531
Branches 14049 14049
=======================================
Hits 36274 36274
Misses 1599 1599
Partials 658 658 🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-10 23:23:12 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 3 non-blocking
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Motivation
contents: write/packages: writeand selects therelease-betaenvironment based only on event fields, so an ambiguous ref can expose high-privilege publishing semantics to the wrong ref.Description
refs/heads/$TAGand failing if a branch with the same short name exists in.github/workflows/orb-beta-release.yml.refs/tags/$TAGwhen runninggh workflow runto ensure the dispatched workflow file is the tag's immutable ref instead of any same-named branch in.github/workflows/orb-beta-release.yml.release-betaenvironment gate to require the workflow to be running on a tag by addinggithub.ref_type == 'tag'to the environment selection expression in.github/workflows/release-selfhost.yml.Testing
npm run actionlintwhich completed successfully (used WASM fallback for actionlint setup in this environment).git diff --checkwhich passed without issues.npm run test:ciwhich exercised the CI gate but failed atcf-typegen:checkbecause the generatedworker-configuration.d.tsis stale in the working tree and needs regeneration vianpm run cf-typegen.npm audit --audit-level=moderatewhich failed due to the npm registry audit endpoint returning403 Forbiddenin this environment.Codex Task