feat(agent): complete Linear project-milestone matching adapter - #4642
feat(agent): complete Linear project-milestone matching adapter#4642jsdevninja wants to merge 2 commits into
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - fixes requiredReview updated: 2026-07-10 10:54:09 UTC
🛑 Suggested Action - Fix Blockers
Review summary Nits — 6 non-blocking
CI checks failing
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
JSONbored
left a comment
There was a problem hiding this comment.
Please, also get this wired up:
The main open question is that `probeLinearWorkspaceAccess` and `createProjectTrackerAdapter` are added and tested but no call site is visible in the diff (`resolveTrackerMatches` still hand-instantiates `new LinearAdapter()`/`new GitHubCompositeProjectTrackerAdapter()` rather than using the factory), so their production wiring can't be confirmed from what's shown.
I'll leave the PR open so you can do this (out of scope of the original issue) but this feature is pointless if not wired up everywhere it should be.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (97.36%) is below the target coverage (99.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4642 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 434 434
Lines 38554 38583 +29
Branches 14053 14059 +6
=======================================
+ Hits 36291 36319 +28
Misses 1604 1604
- Partials 659 660 +1
🚀 New features to boost your workflow:
|
|
Gittensory is closing this pull request on the maintainer's behalf (CI is failing (codecov/patch)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Add workspace project-milestone listing for fuzzy fallback matching, fail-open Linear API degradation, GitHub composite adapter factory, workspace probe helper, and expanded webhook/adapter tests. Closes JSONbored#3186 Co-authored-by: Cursor <cursoragent@cursor.com>
Route fuzzy tracker matching through createProjectTrackerAdapter, export resolveProjectTrackerMatches as the orchestration entrypoint, and add GET /v1/repos/:owner/:repo/linear-workspace-probe for maintainer connectivity checks. Co-authored-by: Cursor <cursoragent@cursor.com>
ec19f14 to
0c26c08
Compare
|
Gittensory is closing this pull request on the maintainer's behalf (CI is failing (codecov/patch)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
|
Rebased on latest main and pushed codecov fix: workspace-probe route test now seeds a registered repo so repo?.installationId is covered. Factory wiring (resolveProjectTrackerMatches -> createProjectTrackerAdapter) and probe route were already in the prior fix commit. |
Summary
projectMilestonesfor fuzzy fallback when Linear's GitHub integration has not already linked the PR, while still preferringattachmentsForURLnative links.GitHubCompositeProjectTrackerAdapter+createProjectTrackerAdapterfactory,probeLinearWorkspaceAccessdiagnostics helper, and fail-open degradation for Linear list API outages (mirrors the GitHub path).Closes #3186
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typecheck(afternpm ci)npm run test:coverageon focused linear/project-tracker suites —src/integrations/linear-adapter.tsat 100% lines/branches;project-tracker-adapter.tspatch arms covered including composite attach delegationnpm run test:workers(not run locally)npm run build:mcpnpm run test:mcp-pack(not run locally)npm run ui:openapi:check(no API schema changes)npm run ui:lint(no UI changes)npm run ui:typecheck(no UI changes)npm run ui:build(no UI changes)npm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:cinot run end-to-end locally (wranglermissing forcf-typegen:checkin this environment). CIvalidateis the authoritative gate.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — agent integration layer only; no visible UI.
Notes