fix(review): stub the live-PR verification fetch in the checkbox commit-delivery test - #4627
Merged
Merged
Conversation
…it-delivery test Main-red: PR #4600 added this test before #4359 (merged same day) started verifying the live PR head/ref/sha inside commitE2eTestToPrBranch before ever writing. #4600 merged on top of #4359 without picking up the stub every sibling commit-delivery test already got in #4359's own diff, so this one test 404s on the live-PR fetch and silently declines the commit -- zero git-write calls, gitWrites stays empty. Adds the same GET /pulls/{n} stub the passing sibling tests already use.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4627 +/- ##
=======================================
Coverage ? 94.10%
=======================================
Files ? 431
Lines ? 38307
Branches ? 13965
=======================================
Hits ? 36050
Misses ? 1600
Partials ? 657 🚀 New features to boost your workflow:
|
Contributor
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 Gittensory is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
Merged
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/unit/queue.test.ts's "PR-panel generate-tests checkbox (feat(review): interactive generate-tests checkbox in ORB's PR comment, maintainer-only #4589) > respects the repo's configured commit delivery mode via the checkbox" fails on a cleanorigin/maincheckout, and was already failing at feat(review): interactive generate-tests checkbox in ORB's PR comment, maintainer-only #4600's own merge commit (4d4635709—validate/validate-codeboth showconclusion: failureon that commit).commitE2eTestToPrBranch(src/github/e2e-test-commit.ts) before it ever writes a commit, and updated every existing commit-delivery test's fetch stub to handle the newGET /pulls/{n}call. feat(review): interactive generate-tests checkbox in ORB's PR comment, maintainer-only #4600 added this NEW checkbox-specific commit-delivery test without that stub (developed in parallel, unaware of fix(review): verify PR head before E2E test commits #4359), so its fetch mock 404s on the live-PR check andcommitE2eTestToPrBranchcorrectly (fail-safe) declines — zero git-write calls,gitWritesstays[].GET /pulls/6011stub the sibling passing tests (commit delivery mode (#4197, #4201)describe block) already use.Test plan
npm run typechecknpx vitest run test/unit/queue.test.ts -t "respects the repo's configured commit delivery mode via the checkbox"— now passesnpx vitest run test/unit/queue.test.ts— full file, 783/783 passing