Skip to content

fix(review): stub the live-PR verification fetch in the checkbox commit-delivery test - #4627

Merged
JSONbored merged 1 commit into
mainfrom
fix/checkbox-e2e-live-pr-stub
Jul 10, 2026
Merged

fix(review): stub the live-PR verification fetch in the checkbox commit-delivery test#4627
JSONbored merged 1 commit into
mainfrom
fix/checkbox-e2e-live-pr-stub

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

Test plan

  • npm run typecheck
  • npx vitest run test/unit/queue.test.ts -t "respects the repo's configured commit delivery mode via the checkbox" — now passes
  • npx vitest run test/unit/queue.test.ts — full file, 783/783 passing

…it-delivery test

Main-red: PR #4600 added this test before #4359 (merged same day) started
verifying the live PR head/ref/sha inside commitE2eTestToPrBranch before ever
writing. #4600 merged on top of #4359 without picking up the stub every
sibling commit-delivery test already got in #4359's own diff, so this one
test 404s on the live-PR fetch and silently declines the commit -- zero
git-write calls, gitWrites stays empty. Adds the same GET /pulls/{n} stub
the passing sibling tests already use.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@53bd82b). Learn more about missing BASE report.
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4627   +/-   ##
=======================================
  Coverage        ?   94.10%           
=======================================
  Files           ?      431           
  Lines           ?    38307           
  Branches        ?    13965           
=======================================
  Hits            ?    36050           
  Misses          ?     1600           
  Partials        ?      657           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored JSONbored self-assigned this Jul 10, 2026
@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 10, 2026
@loopover-orb

loopover-orb Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Important

🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪

🔍 Gittensory is reviewing…

AI analysis is in progress. This comment will update when the review is complete.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing

@JSONbored
JSONbored merged commit 2544969 into main Jul 10, 2026
11 checks passed
@JSONbored
JSONbored deleted the fix/checkbox-e2e-live-pr-stub branch July 10, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant