Skip to content

fix(review): mark firstLineMatching's noUncheckedIndexedAccess fallback unreachable #4588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 10, 2026
Merged

fix(review): mark firstLineMatching's noUncheckedIndexedAccess fallback unreachable #4588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/review/content-lane/security-scan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,11 @@ const PIPED_INSTALL_RE = /\b(?:curl|wget)\b[^\n|]*\|\s*(?:sudo\s+)?(?:sh|bash|zs
function firstLineMatching(text: string, re: RegExp): { n: number; text: string } | null {
const lines = text.split(/\r?\n/);
for (let i = 0; i < lines.length; i += 1) {
if (re.test(lines[i] ?? "")) return { n: i + 1, text: (lines[i] ?? "").trim().slice(0, 160) };
// `?? ""` only exists to satisfy noUncheckedIndexedAccess -- the loop bound above guarantees lines[i] is
// always defined here (`.split()` never produces holes), so the fallback branch is unreachable in practice.
/* v8 ignore next */
const line = lines[i] ?? "";
if (re.test(line)) return { n: i + 1, text: line.trim().slice(0, 160) };
}
return null;
}
Expand Down