Skip to content

feat(miner-ui): scaffold apps/gittensory-miner-ui dashboard shell - #4572

Closed
RealDiligent wants to merge 1 commit into
JSONbored:mainfrom
RealDiligent:feat/miner-ui-scaffold-4303
Closed

feat(miner-ui): scaffold apps/gittensory-miner-ui dashboard shell#4572
RealDiligent wants to merge 1 commit into
JSONbored:mainfrom
RealDiligent:feat/miner-ui-scaffold-4303

Conversation

@RealDiligent

Copy link
Copy Markdown
Contributor

Summary

  • Add \�pps/gittensory-miner-ui/\ as a local-only Vite + TanStack Router SPA scaffold for the miner dashboard shell
  • Wire the new workspace into root \ui:*\ scripts and CI \ui\ path filters
  • README documents why deploy model differs from \�pps/gittensory-ui\ (no TanStack Start / Cloudflare)

Closes #4303

Test plan


  • pm run build --workspace=@jsonbored/gittensory-miner-ui\

  • pm run typecheck --workspace=@jsonbored/gittensory-miner-ui\

  • pm run test --workspace=@jsonbored/gittensory-miner-ui\

  • pm run lint --workspace=@jsonbored/gittensory-miner-ui\
  • CI green on upstream PR

Made with Cursor

@RealDiligent
RealDiligent requested a review from JSONbored as a code owner July 10, 2026 04:36
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

Add a local-only Vite + TanStack Router SPA scaffold for the miner
dashboard, wire it into root ui:* scripts and CI path filters.

Closes JSONbored#4303

Co-authored-by: Cursor <cursoragent@cursor.com>
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.10%. Comparing base (3f23c61) to head (e35cd0f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4572   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files         427      427           
  Lines       38022    38022           
  Branches    13877    13877           
=======================================
  Hits        35779    35779           
  Misses       1586     1586           
  Partials      657      657           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 10, 2026
@loopover-orb

loopover-orb Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - reject/close recommended

Review updated: 2026-07-10 04:52:14 UTC

18 files · 1 AI reviewer · 1 blocker · readiness 100/100 · CI green · unstable

🛑 Suggested Action - Reject/Close

  • Linked issue overlaps another open PR — Review the related PRs before spending reviewer time on duplicate work.

Review summary
This PR adds apps/gittensory-miner-ui/ as a bare Vite + TanStack Router + Tailwind v4 SPA scaffold (React 19), mirroring gittensory-ui's tooling versions but intentionally dropping the TanStack Start/Cloudflare deploy model per the README. It wires the workspace into root ui:build/lint/typecheck/test scripts and the CI ui path filter, with one smoke test for the single IndexPage route. The scaffold is correctly empty by design (Phase 6 placeholder), closes #4303, and all CI checks passed on this commit with no scope creep visible in the diff.

Nits — 6 non-blocking
  • vite.config.ts:10,14 hardcodes dev/preview ports 5174/4174 with no comment explaining the offset from gittensory-ui's 5173/4173.
  • src/routes/__root.tsx's nav Link and header layout have no test coverage — only IndexPage is exercised in app.test.tsx.
  • vite@​7.3.1, a brand-new devDependency, has several open OSV advisories (GHSA-4w7w-66w2-5vf9, GHSA-fx2h-pf6j-xcff, GHSA-p9ff-h696-f583, GHSA-v2wj-q39q-566r, GHSA-v6wh-96g9-6wx3) of unknown severity — worth checking for a patched 7.x release before merge.
  • src/routeTree.gen.ts is committed despite being fully regenerated by TanStackRouterVite on every build; consider gitignoring it alongside dist/ to avoid diff noise.
  • Test-to-code ratio is low (1 test file for 7 source files), acceptable for an intentionally-empty scaffold but worth tightening once real views land in follow-up issues.
  • Diff looks like trivial or whitespace-only churn — Reduce whitespace-only or formatting-only churn and keep the diff focused on substantive changes.

Why this is blocked

  • Linked issue overlaps another open PR — Review the related PRs before spending reviewer time on duplicate work.
Signal Result Evidence
Code review ❌ 1 blocker 1 reviewer
Linked issue ✅ Linked #4303
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 314 registered-repo PR(s), 128 merged, 19 issue(s).
Contributor context ✅ Confirmed Gittensor contributor RealDiligent; Gittensor profile; 314 PR(s), 19 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Linked issue satisfaction

Addressed
The diff adds a self-contained apps/gittensory-miner-ui scaffold (package.json, vite.config.ts, TanStack Router routes, tailwind styles, eslint/prettier configs, tsconfig, tests) mirroring gittensory-ui's dependency versions, avoids wrangler/@​lovable.dev deps in favor of a plain Vite dev/build setup, adds matching typecheck/lint/test/build scripts, wires it into root ui:* scripts and CI path filte

Review context
  • Author: RealDiligent
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 314 PR(s), 19 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before / after /
/ mobile before / (mobile) after / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 10, 2026
@loopover-orb

loopover-orb Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Gittensory is closing this pull request on the maintainer's behalf (Linked issue overlaps another open PR; duplicate of another open PR). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(miner-ui): scaffold apps/gittensory-miner-ui/ dashboard shell

1 participant