Skip to content

fix(selfhost): build gittensory-engine before bundling in deploy-selfhost-prebuilt.sh #4533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 9, 2026
Merged

fix(selfhost): build gittensory-engine before bundling in deploy-selfhost-prebuilt.sh #4533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/deploy-selfhost-prebuilt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ run_node_build() {
-v "$PWD:/work" \
-w /work \
"$NODE_IMAGE" \
sh -lc 'npm ci --ignore-scripts && node scripts/build-selfhost.mjs --all && node scripts/validate-selfhost-sourcemap.mjs'
sh -lc 'npm ci --ignore-scripts && npm --workspace @jsonbored/gittensory-engine run build && node scripts/build-selfhost.mjs --all && node scripts/validate-selfhost-sourcemap.mjs'
}

run_sentry_upload() {
Expand Down
11 changes: 11 additions & 0 deletions test/unit/docs-selfhost-update-rollback.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,17 @@ describe("self-host update + rollback docs (#1823)", () => {
expect(prebuiltScript).toContain('up -d --no-deps "$SERVICE"');
});

it("prebuilt deploy builds the gittensory-engine workspace before bundling (#4530)", () => {
// packages/gittensory-engine/dist/ is gitignored and built via `tsc`; `npm ci --ignore-scripts`
// never triggers that build on its own, so anything that imports the engine (e.g.
// packages/gittensory-miner) fails to resolve during the --all bundle unless this runs first.
const engineBuildIndex = prebuiltScript.indexOf("@jsonbored/gittensory-engine run build");
const bundleIndex = prebuiltScript.indexOf("build-selfhost.mjs --all");
expect(engineBuildIndex).toBeGreaterThan(-1);
expect(bundleIndex).toBeGreaterThan(-1);
expect(engineBuildIndex).toBeLessThan(bundleIndex);
});

it("post-update script probes /ready without mutating operator-owned state", () => {
expect(postUpdateScript).toContain("/ready");
expect(postUpdateScript).toContain("GITTENSORY_IMAGE");
Expand Down