fix(github): stop treating a completed third-party action_required check as pending CI - #4396
Merged
Merged
Conversation
…eck as pending CI reduceLiveCiAggregate excluded "action_required" from its failing-conclusion set to protect a real scenario (a github-actions workflow awaiting maintainer "Approve and run"), but the exclusion applied to EVERY app, not just github-actions. A third-party app's own COMPLETED check-run reporting action_required as its terminal verdict (e.g. a security/trust-scan tool flagging a contributor) fell through to the same "still pending" bucket, and since that verdict can never change via any CI event gittensory observes, prReadyForReview deferred the review indefinitely -- confirmed live across multiple PRs stuck 30+ minutes across repeated outage-repair attempts before exhausting the repair cap and falling back to slow passive sweep cadence, effectively never reviewed. Now only a github-actions check's action_required is treated as awaiting-approval pending CI; any other app's completed action_required check-run is treated as a settled, non-blocking result instead.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4396 +/- ##
=======================================
Coverage 93.96% 93.96%
=======================================
Files 401 401
Lines 36869 36871 +2
Branches 13480 13482 +2
=======================================
+ Hits 34644 34646 +2
Misses 1569 1569
Partials 656 656
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reduceLiveCiAggregate's check-run classification excludesaction_requiredfrom its failing-conclusion set on purpose, to protect a real scenario: a github-actions workflow awaiting maintainer "Approve and run" surfaces that way, and it is genuinely not-yet-run, not a failure.action_requiredas its terminal verdict (e.g. a security/trust-scan tool flagging a contributor) fell through to the exact same "still pending" bucket.prReadyForReviewdeferred the review indefinitely — confirmed live: a PR stuck 30+ minutes across 8 outage-repair attempts before exhaustingREGATE_REPAIR_MAX_ATTEMPTS_PER_SHAand falling back to slow passive sweep cadence, effectively never reviewed.github-actions-app check'saction_requiredis treated as awaiting-approval pending CI now. Any other app's already-completedcheck-run reportingaction_requiredis treated as a settled, non-blocking result (likeneutral/skipped) instead — conservative default (an unknown/absent app slug stays pending, matching prior behavior) so this only changes behavior for a confirmed non-Actions app.Scope
wantedPaths(src/,test/)site/,CNAME,**/lovable/**, orCHANGELOG.mdValidation
npm run typechecknpx vitest run test/unit/backfill.test.ts— 213/213 passing (no regressions), incl. 4 new tests: the third-party-settled fix, a regression test for the original github-actions awaiting-approval protection, an app-less conservative-pending case, and a not-yet-completed third-party casegit diff origin/main)Safety
app.slugis confirmed and is NOTgithub-actions; every other case (unknown app, github-actions itself, not yet completed) keeps deferring exactly as before