test(ui): add AGPL-3.0 badge to footer to validate visual-capture pipeline - #4180
Closed
JSONbored wants to merge 2 commits into
Closed
test(ui): add AGPL-3.0 badge to footer to validate visual-capture pipeline#4180JSONbored wants to merge 2 commits into
JSONbored wants to merge 2 commits into
Conversation
…eline Deliberate small, real, visible test change -- not a feature PR. Used to confirm the newly-activated before/after screenshot capture pipeline renders correctly end-to-end on a real gittensory-ui PR (production before-shot vs. this PR's preview-deploy after-shot).
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 59275be | Commit Preview URL Branch Preview URL |
Jul 08 2026, 07:09 PM |
Contributor
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-08 20:32:30 UTC
⏸️ Suggested Action - Manual Review
Nits — 1 non-blocking
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
This was referenced Jul 8, 2026
Closed
…cket Empty commit to force a fresh gittensory-orb capture cycle after wiring edge-us-01 to REVIEW_AUDIT_S3_PUBLIC_URL, to confirm screenshot URLs now point at the public bucket instead of the Tailscale-only origin.
JSONbored
added a commit
that referenced
this pull request
Jul 16, 2026
…ntry can see them Advances #6325 -- covers the alerting half only; the issue stays open until the live PUBLIC_API_ORIGIN misconfiguration itself is corrected. sqliteBackupAdvisory and publicOriginReachabilityAdvisory both log via console.warn with the explicit intent to "warn LOUDLY" -- but installStructuredLogForwarding (wired inside initSentry) only intercepts console.log (forwarded only with an explicit level:error/fatal) and console.error (always forwarded); console.warn is never wrapped at all. Both advisories were therefore silently unreachable by Sentry regardless of whether Sentry was configured or the advisory condition was true. Confirmed live: the self-hosted instance reviewing JSONbored's own repos has PUBLIC_API_ORIGIN set to a bare Tailscale hostname (edge-nl-01.raccoon-bushi.ts.net) with no Funnel serve/funnel config enabled on that node (verified via `tailscale funnel status` / `tailscale serve status`, both "No serve config") -- genuinely, provably unreachable from GitHub's public image-fetching servers, not a false-positive Funnel case. publicOriginReachabilityAdvisory exists specifically to catch this (#4180), and PUBLIC_ORIGIN_ACKNOWLEDGED is unset on that box, so the advisory has been firing at every boot the whole time -- just never reaching anyone, because of this bug. Switches both advisories from console.warn to console.error. `level: "warn"` stays in the JSON payload, so this only changes which console method reaches the Sentry forwarder, not the reported severity (forwardStructuredLogToSentry still maps it to Sentry's "warning" level, not "error"). emptyConfigDirAdvisory has the identical bug but fires BEFORE initSentry in the boot sequence, so the same one-line fix doesn't help it -- that needs the Sentry-init call moved earlier, a distinct and slightly riskier change, tracked separately rather than scope-creeping into this PR. The live PUBLIC_API_ORIGIN value itself is unchanged by this PR -- fixing the actual misconfiguration (pointing it at a genuinely public origin, or enabling Funnel) is an infra decision for the operator, not a code change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
BadgeUI component,variant="outline") purely to validate the newly-activated before/after visual-capture pipeline end-to-end on a real gittensory-ui PR.preview_eval/DOM inspection confirmed the badge renders with the correct classes and a real, visible bounding box).Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm --workspace @jsonbored/gittensory-ui run typechecknpm --workspace @jsonbored/gittensory-ui run lint(0 errors; pre-existing warnings elsewhere untouched)npm --workspace @jsonbored/gittensory-ui run format(no changes needed)npm run ui:buildnpm run test:coverage-- N/A,apps/**is not measured by Codecov and nosrc/**logic changed.Safety
UI Evidence
Intentionally left blank -- this PR's entire purpose is to let the bot's own visual-capture pipeline produce that evidence automatically. See the gittensory-orb review comment for the actual before/after table once it renders.
Notes
apps/gittensory-ui/src/components/**is in this repo'shardGuardrailGlobs) -- that's expected and fine, this isn't meant to auto-merge.