fix(mcp): build gittensory-engine before the publish gate + switch to workflow_dispatch

[JSONbored]

Summary

• npm-publish.yml never built @jsonbored/gittensory-engine before running the MCP release validation gate, unlike ci.yml. That package's dist/ is gitignored, so every publish attempt fails the moment the test suite imports src/mcp/find-opportunities.ts (transitively pulls in gittensory-engine via gittensory-miner's opportunity-fanout.js).
• Reproduced live today: pushing the mcp-v0.7.0 tag triggered the workflow, which failed at the "MCP release validation gate" step — before the tarball/publish steps, so nothing was published to npm.
• Also switches the trigger from push: tags: to workflow_dispatch, needed for the release-automation follow-up (a GITHUB_TOKEN-created tag doesn't fire push-triggered workflows). Version/tag are now resolved from the dispatched commit's package.json rather than the tag ref; the tag is created if it doesn't already exist (self-tag, matching the old manual flow) or verified to point at HEAD if it does.

Test plan

• npm run actionlint — clean
• Reproduced the exact CI failure locally by removing packages/gittensory-engine/dist and confirming require("@jsonbored/gittensory-engine") fails the same way; confirmed npm run build --workspace @jsonbored/gittensory-engine resolves it
• After merge: manually dispatch this workflow against main to complete the stalled mcp-v0.7.0 publish (tag already exists, points at the merged v0.7.0 commit)

[superagent-security]

Superagent found 2 security concern(s).

[superagent-security]

Superagent found 1 security concern(s).

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.71%. Comparing base (06689bc) to head (fdf847d).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4135   +/-   ##
=======================================
  Coverage   93.71%   93.71%           
=======================================
  Files         385      385           
  Lines       36197    36197           
  Branches    13264    13264           
=======================================
  Hits        33921    33921           
  Misses       1618     1618           
  Partials      658      658           

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-08 07:40:45 UTC}

1 file · 1 AI reviewer · 2 blockers · readiness 93/100 · CI green · unknown

⏸️ Suggested Action - Manual Review

• No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
• Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Review summary
This PR fixes a real, reproduced bug: npm-publish.yml never built @​jsonbored/gittensory-engine before running test:release:mcp, so every publish attempt failed at the validation gate before anything reached npm (confirmed by the stalled mcp-v0.7.0 tag). It also switches the trigger to workflow_dispatch (required since GITHUB_TOKEN-created tags don't fire push triggers) and splits the job into an unprivileged validate job (build/test/pack/smoke-test, contents: read only) and a privileged publish job (environment: release, contents: write + id-token: write) that publishes the exact tarball artifact validate already tested. The permission split, tag create-vs-verify handoff between the two jobs, and version/tag propagation via job outputs are all internally consistent and correctly scoped.

Nits — 6 non-blocking

• The tag-existence check is duplicated almost verbatim between the validate job's 'Resolve release version' step and the publish job's 'Create or verify release tag' step — worth a shared shell function or composite action if this workflow gets touched again.
• Superagent Security Scan is failing with 'PR requires security review' given the new contents: write/id-token: write escalation and environment: release gate — make sure that manual security review actually happens before merging, since CI won't block it for you.
• No linked issue in the PR description per repo convention for contributor PRs, though this reads as a maintainer hotfix for a live, reproduced failure rather than unsolicited feature work.
• Consider factoring the tag-existence check (.github/workflows/npm-publish.yml, both in 'Resolve release version' and 'Create or verify release tag') into one reusable step/script to avoid drift between the two copies.
• Explicitly confirm in the PR or a follow-up comment that the 'release' GitHub environment has reviewer-approval protection configured in repo settings, since the whole privilege-separation design depends on that being true and it isn't visible from the diff.
• Diff looks like trivial or whitespace-only churn — Reduce whitespace-only or formatting-only churn and keep the diff focused on substantive changes.

Concerns raised — review before merging

• No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
• Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Signal	Result	Evidence
Code review	❌ 2 blockers	1 reviewer
Linked issue	⚠️ Missing	No linked issue or no-issue rationale found.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 52 registered-repo PR(s), 43 merged, 496 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 52 PR(s), 496 issue(s).
Gate result	❌ Blocking	Repo-configured hard blocker found.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, TypeScript, JavaScript, Ruby, Go, Kotlin, MDX, Shell
• Official Gittensor activity: 52 PR(s), 496 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.
• Explain no-issue PR.
• Link the issue being solved, or explicitly explain why this is a no-issue PR.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review