fix(review): apply the no-issue-rationale exemption to all linked-issue findings

[JSONbored]

Summary

No issue: found and fixed as part of the ongoing review-stack reliability sweep; a self-contained follow-up didn't seem worth its own tracking issue.

• The "Linked issue" review-panel signal row already recognizes hasClearNoIssueRationale(pr) and shows a passing "no-issue rationale" state when a PR body has one, but 3 separate finding-generation sites never checked it, so they kept emitting missing-linked-issue findings anyway:
  • buildPreflightResult's missing_linked_issue (pre-flight/planning path)
  • buildPullRequestMaintainerPacket's missing_linked_issue (PR-review path)
  • buildFocusManifestGuidance's manifest_linked_issue_required (maintainer focus-manifest policy) — now accepts a caller-computed hasNoIssueRationale param since this function has no PR title/body of its own; both callers (src/signals/local-branch.ts, src/queue/processors.ts) now pass it via hasClearNoIssueRationale.
• Discovered live on PR fix(queue): queue all issue-linked PR regates #3989 (JSONbored/gittensory): its body had a valid No issue: ... rationale, the Linked Issue signal correctly showed it, yet the panel still counted 2 blockers and repeated "No linked issue detected" in Suggested Action.

Test plan

• npm run typecheck — clean
• npx vitest run test/unit/signals-coverage.test.ts test/unit/signals-v2.test.ts test/unit/signals.test.ts test/unit/focus-manifest.test.ts test/unit/local-branch.test.ts test/unit/queue.test.ts — all passed, including 3 new regression tests (one per site) proving the exemption, plus one existing test's assertion corrected (it was asserting the pre-fix buggy behavior for a fixture whose body already had a rationale)

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-07 21:09:37 UTC}

7 files · 1 AI reviewer · 2 blockers · readiness 100/100 · CI green · clean

⏸️ Suggested Action - Manual Review

• No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
• Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Review summary
This PR closes a real gap: three finding-generation sites (buildPreflightResult, buildPullRequestMaintainerPacket, buildFocusManifestGuidance) independently re-implemented the missing-linked-issue check without consulting the existing hasClearNoIssueRationale helper that the review-panel signal already uses, causing a live false-positive (PR #3989) where the panel showed a passing Linked Issue signal but still emitted missing_linked_issue findings. The fix threads the same rationale check into all three sites — two by calling hasClearNoIssueRationale directly, and buildFocusManifestGuidance via a caller-computed boolean param to avoid a circular import — which is the correct root-cause-layer fix rather than a symptom patch. Each site got a targeted regression test, and one pre-existing test assertion that encoded the old buggy behavior was corrected to match reality; this is real coverage of the actual production path, not a fabricated scenario.

Nits — 5 non-blocking

• src/signals/focus-manifest.ts's new hasNoIssueRationale param has a 4-line inline comment explaining the circular-dependency rationale — consider trimming it to one line since the WHY (avoid circular import) is the only non-obvious part.
• Confirm `title` is already in scope at the buildLocalBranchAnalysis call site in src/signals/local-branch.ts (not shown in the diff) before hasClearNoIssueRationale({ title, body: args.input.body }) is called.
• The PR description cites PR fix(queue): queue all issue-linked PR regates #3989 as the discovery source but doesn't link a tracking issue for this fix — worth confirming this qualifies as an exempt maintainer self-fix under the repo's issue-linking convention rather than needing an explicit issue reference.
• The three near-identical REGRESSION tests (one per site) could share a small fixture/helper to reduce duplication across signals-v2.test.ts, signals-coverage.test.ts, and focus-manifest.test.ts.
• Consider a single shared test helper (e.g. `expectNoIssueExemption(builderFn, args)`) to DRY up the three near-duplicate regression tests.

Concerns raised — review before merging

• No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
• Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Signal	Result	Evidence
Code review	❌ 2 blockers	1 reviewer
Linked issue	✅ No-issue rationale	PR body explains why no issue is linked.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 51 registered-repo PR(s), 43 merged, 532 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 51 PR(s), 532 issue(s).
Gate result	❌ Blocking	Repo-configured hard blocker found.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, TypeScript, JavaScript, Ruby, Go, Kotlin, MDX, Shell
• Official Gittensor activity: 51 PR(s), 532 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.
• Link the issue being solved, or explicitly explain why this is a no-issue PR.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.59%. Comparing base (1deb96c) to head (69a0da6).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4064   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files         380      380           
  Lines       35596    35597    +1     
  Branches    13050    13051    +1     
=======================================
+ Hits        33316    33317    +1     
  Misses       1618     1618           
  Partials      662      662           

Files with missing lines	Coverage Δ
src/queue/processors.ts	94.95% <ø> (ø)
src/signals/engine.ts	97.45% <100.00%> (ø)
src/signals/focus-manifest.ts	99.62% <100.00%> (+<0.01%)	⬆️
src/signals/local-branch.ts	97.18% <ø> (ø)

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.