feat(review): render single-line ```suggestion block on inline comments (#2139) - #4045
Conversation
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4045 +/- ##
=======================================
Coverage ? 93.78%
=======================================
Files ? 394
Lines ? 36628
Branches ? 13403
=======================================
Hits ? 34351
Misses ? 1622
Partials ? 655
🚀 New features to boost your workflow:
|
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review result - approve/merge recommendedReview updated: 2026-07-07 14:15:28 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 5 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
…erage The formatInlineBody → anchoredSuggestionBlock pipeline already renders GitHub-native ```suggestion fences when enabled; add the remaining JSONbored#2139 deliverable tests for multi-line suggestion text preserved verbatim and document the issue cross-reference. Co-authored-by: Cursor <cursoragent@cursor.com>
4a92c6a to
eca6e15
Compare
Summary
Closes #2139. The
formatInlineBody→anchoredSuggestionBlock→safeSuggestionBlockpipeline already renders GitHub-native```suggestionfences whenreview.suggestionsis enabled (landed via #1956 / #3577, with added-line anchor safety via #2140). This PR completes the remaining #2139 acceptance criteria:safeSuggestionBlock.formatInlineBodydocs and the inline-comment test suite.Deliverables checklist (#2139)
formatInlineBodyappends a fenced```suggestionblock whenfinding.suggestionis set and suggestions are enabledcomposeInlineFindings)Test plan
npx vitest run test/unit/inline-comments.test.ts test/unit/inline-suggestion-anchor.test.tsnpx tsc --noEmitinline-comments.ts+inline-suggestion-anchor.ts(patch-local)