fix(test): resolve accumulated main-red drift from 3 recent merges - #4019
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 52 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - fixes requiredReview updated: 2026-07-07 10:40:35 UTC
🛑 Suggested Action - Manual Review
Review summary Nits — 3 non-blocking
Why this is blocked
CI checks failing
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Three independent test/doc mismatches accumulated on main from recently merged PRs, each blocking every subsequent PR's validate-code: - queue.test.ts: 4 disposition-metric assertions predated #3946's repo label redaction and still expected the unredacted literal repo name. - predicted-gate-engine-coverage.test.ts: 3 duplicate-winner assertions predated #3956's anti-backdating fix and asserted the old createdAt- based ordering instead of the new claim-time-only, fail-closed one. - gittensory.full.yml: missing the review.shared_config (#2046) doc section that .gittensory.yml.example already had, breaking their required byte-identical-from-marker sync.
e53acd8 to
cc25e92
Compare
Summary
Main was red from three independent, unrelated test/doc mismatches that each accumulated from a recently-merged PR, blocking validate-code for every subsequent PR:
test/unit/queue.test.ts: 4 disposition-metric assertions predated fix(selfhost): redact agent disposition metric repo labels #3946'srepolabel redaction ongittensory_agent_disposition_totaland still expected the unredacted literal repo name instead ofrepo="redacted-1".test/unit/predicted-gate-engine-coverage.test.ts: 3 duplicate-winner assertions predated fix(review): prevent backdated duplicate-winner claims #3956's anti-backdating fix and asserted the oldcreatedAt-based ordering instead of the new claim-time-only, fail-closed semantics (acreatedAt-only pair with nolinkedIssueClaimedAtnow correctly returnsfalse/null, nottrue/a resolved winner).config/examples/gittensory.full.yml: missing thereview.shared_config(feat(config): add review.shared_config operator base-manifest overlay #2046, from feat(config): add review.shared_config operator base-manifest overlay (#2046) #3995) doc section that.gittensory.yml.examplealready has, breaking the two files' required byte-identical-from-marker sync.Scope
Validation
npx tsc --noEmit— clean.npx vitest run test/unit/queue.test.ts test/unit/predicted-gate-engine-coverage.test.ts test/unit/duplicate-winner.test.ts test/unit/config-templates.test.ts— all pass.npm run test:coverage— clean.Safety
site//CNAME/lovablechanges.