Skip to content

fix(db): dedupe focus manifest snapshots #4015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 7, 2026
Merged

fix(db): dedupe focus manifest snapshots #4015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/db/retention.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,12 @@ export async function pruneExpiredRecords(

export type SignalSnapshotDedupeResult = { signalType: string; deleted: number };

const LATEST_ONLY_SIGNAL_SNAPSHOT_TYPES = ["repo-culture-profile", "repo-doc-refresh-attempt"] as const;
const LATEST_ONLY_SIGNAL_SNAPSHOT_TYPES = [
"repo-culture-profile",
"repo-doc-refresh-attempt",
"repo-focus-manifest",
"repo-public-focus-manifest",
] as const;

/**
* signal_snapshots has no dedup: `generate-signal-snapshots` inserts a NEW row per (signal_type,
Expand Down
20 changes: 20 additions & 0 deletions test/unit/retention.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { getDb } from "../../src/db/client";
import { dedupeSignalSnapshots, pruneExpiredRecords, RETENTION_POLICY } from "../../src/db/retention";
import { agentContextSnapshots, aiUsageEvents, webhookEvents } from "../../src/db/schema";
import { processJob, runRetentionPrune } from "../../src/queue/processors";
import { REPO_FOCUS_MANIFEST_SIGNAL, REPO_PUBLIC_FOCUS_MANIFEST_SIGNAL } from "../../src/signals/focus-manifest-loader";
import { createTestEnv } from "../helpers/d1";

const NOW = Date.parse("2026-06-13T00:00:00.000Z");
Expand Down Expand Up @@ -161,6 +162,25 @@ describe("dedupeSignalSnapshots", () => {
expect(remaining?.id).toBe("s-3");
});

it("dedupes private and public focus-manifest cache snapshots (regression for storage exhaustion)", async () => {
const env = createTestEnv();
await insertSignalSnapshot(env, "private-old", REPO_FOCUS_MANIFEST_SIGNAL, "JSONbored/gittensory", "2026-06-01T00:00:00.000Z");
await insertSignalSnapshot(env, "private-latest", REPO_FOCUS_MANIFEST_SIGNAL, "JSONbored/gittensory", "2026-06-02T00:00:00.000Z");
await insertSignalSnapshot(env, "public-old", REPO_PUBLIC_FOCUS_MANIFEST_SIGNAL, "JSONbored/gittensory", "2026-06-01T00:00:00.000Z");
await insertSignalSnapshot(env, "public-latest", REPO_PUBLIC_FOCUS_MANIFEST_SIGNAL, "JSONbored/gittensory", "2026-06-02T00:00:00.000Z");

const results = await dedupeSignalSnapshots(env);

expect(results).toEqual([
{ signalType: REPO_FOCUS_MANIFEST_SIGNAL, deleted: 1 },
{ signalType: REPO_PUBLIC_FOCUS_MANIFEST_SIGNAL, deleted: 1 },
]);
expect(await countSignalSnapshots(env, REPO_FOCUS_MANIFEST_SIGNAL)).toBe(1);
expect(await countSignalSnapshots(env, REPO_PUBLIC_FOCUS_MANIFEST_SIGNAL)).toBe(1);
const rows = await env.DB.prepare("SELECT id FROM signal_snapshots ORDER BY signal_type, id").all<{ id: string }>();
expect(rows.results.map((row) => row.id)).toEqual(["private-latest", "public-latest"]);
});

it("preserves bounded history for signal types read as historical series", async () => {
const env = createTestEnv();
await insertSignalSnapshot(env, "decision-prev", "contributor-decision-pack", "alice", "2026-06-01T00:00:00.000Z");
Expand Down