fix(review): stop draft PRs from re-triggering AI review - #4014
Merged
Conversation
A push to a draft PR was silently re-running the full AI reviewer on every commit, letting contributors iterate for free while tokens kept burning. review.auto_review.skip_drafts already exists and is fully wired (src/signals/focus-manifest.ts) but was unset. Also enables skip_docs_only, since a docs-only PR never needs an AI pass.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
loopover-orb
Bot
added
the
gittensor:bug
❌ 57 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
review.auto_review.skip_draftsandskip_docs_onlywere fully implemented and wired but unset in this repo's own.gittensory.yml, so a push to a draft PR was still triggering a full AI review pass on every commit. Enables both for JSONbored/gittensory. Companion PRs will do the same for metagraphed and awesome-claude (config lives per-repo, can't be one PR).src/config/gittensory-repo-focus-manifest.ts) to keep it byte-identical with the root.gittensory.yml, per its own "keep aligned" header comment.Part of #3999.
Closes #3999.
Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlint(no workflow files touched)npm run typechecknpm run test:coverage— not run in full; this is a config/data-only change (no new logic branches). Ran the specific existing suite (test/unit/gittensory-focus-manifest.test.ts, 13/13 passing) confirming the bundled fallback constant still parses and matches the schema.npm run test:workers(no Workers-pool-relevant code touched)npm run build:mcp/npm run test:mcp-pack(not touched)npm run ui:openapi:check(no API/schema change)npm run ui:lint/ui:typecheck/ui:build(no UI files touched)npm audit --audit-level=moderate— not re-run; no dependency changes in this PR.npm run docs:drift-checkandnpm run selfhost:config-lint -- .gittensory.ymlboth pass, confirming the newreviewfield parses and is recognized.If any required check was skipped, explain why:
src/logic branches were added, so the full CI matrix (UI build/lint, MCP pack, Workers pool, etc.) isn't relevant to this diff. The two checks that are relevant (typecheck, the manifest-constant unit test) are green.Safety
UI Evidencesection — N/A, no UI change.Notes