fix(settings): bound contributor open caps - #3977
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 59eeb91 | Commit Preview URL Branch Preview URL |
Jul 07 2026, 08:33 AM |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 9 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 5 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - fixes requiredReview updated: 2026-07-07 08:42:17 UTC
🛑 Suggested Action - Manual Review
Review summary Nits — 5 non-blocking
Why this is blocked
CI checks failing
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Motivation
Description
MAX_CONTRIBUTOR_OPEN_ITEM_CAP = 100and document the bound insrc/types.ts.normalizeOpenItemCaptoMath.min(value, MAX_CONTRIBUTOR_OPEN_ITEM_CAP)insrc/db/repositories.tsso DB-roundtrips cannot store values above the enforcement sample.normalizeOptionalContributorOpenItemCaphelper inpackages/gittensory-engine/src/focus-manifest.tsso.gittensory.ymloverrides also cannot exceed the live-check budget while preservingnullclears and invalid-value warnings..max(MAX_CONTRIBUTOR_OPEN_ITEM_CAP)forcontributorOpenPrCapandcontributorOpenIssueCapinsrc/openapi/schemas.tsand regenerate the UI OpenAPI artifact.test/unit/data-spine.test.ts,test/unit/focus-manifest.test.ts, andtest/unit/ci-openapi-settings-parity.test.tsthat assert clamping and schema rejection above 100.Testing
git diff --checkwhich produced no issues.npx vitest run test/unit/data-spine.test.ts test/unit/focus-manifest.test.ts test/unit/ci-openapi-settings-parity.test.ts test/unit/duplicate-winner.test.tsand they all passed locally.npm run typecheckandnpm run ui:openapi:check(the OpenAPI file was regenerated) and both succeeded.npm run test:coverageandnpm audit --audit-level=moderate;test:coveragetimed out / hit long-running existing suites in this environment and was aborted, andnpm auditfailed with a403from the npm audit endpoint (network registry error), so full coverage/audit could not be completed here.Codex Task