Skip to content

feat(settings): generate repo onboarding pack preview for accepted repos - #395

Merged
JSONbored merged 5 commits into
JSONbored:mainfrom
kiannidev:feat/issue-248-onboarding-pack-clean
Jun 5, 2026
Merged

feat(settings): generate repo onboarding pack preview for accepted repos#395
JSONbored merged 5 commits into
JSONbored:mainfrom
kiannidev:feat/issue-248-onboarding-pack-clean

Conversation

@kiannidev

@kiannidev kiannidev commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #248

Summary

  • Adds a repo policy compiler (compileRepoPolicyCompilerOutput) that normalizes focus-manifest policy into structured output for onboarding-pack generation (feeds feat(settings): add repo policy compiler for focus manifests #277feat(settings): generate repo onboarding pack for accepted Gittensory repos #248 without duplicating manifest parsing).
  • Wires preview-only onboarding packs for accepted (registered) repos via GET /v1/repos/{owner}/{repo}/onboarding-pack/preview (maintainer / owner / operator roles).
  • Pack content includes contribution lanes, label policy, validation expectations, readiness warnings, maintainer expectations, and public-output boundaries; previewMarkdown is sanitized and publication remains preview_only / allowed: false.
  • Extends test/unit/onboarding-pack.test.ts and adds test/unit/repo-policy-compiler.test.ts for compiler→pack pipeline, sanitizer boundaries, and registered-repo gating.

Scope

  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; global coverage stays at or above 97% for lines, statements, functions, and branches (aim for 98%+ branch coverage locally so CI variance does not fail near the threshold)
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

New / updated tests: test/unit/onboarding-pack.test.ts, test/unit/repo-policy-compiler.test.ts.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include screenshots or a short recording.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

Notes

kiannidev and others added 2 commits June 4, 2026 22:47
Add policy compiler output → sanitized preview-only onboarding pack,
GET preview API for registered repos, and tests for sanitizer boundaries.

Fixes JSONbored#248
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep onboarding-pack preview import alongside PublicSurfaceSkipReason
from upstream settings-preview changes.
@kiannidev
kiannidev force-pushed the feat/issue-248-onboarding-pack-clean branch from bbaea15 to 8def252 Compare June 4, 2026 20:57

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiannidev this looks mergeable to me.

A few notes:

  • The preview endpoint is connected to the registration-readiness path and is represented in OpenAPI.
  • The policy compiler coverage is the right validation layer for this change.
  • No code changes requested from me; merge after the required review gate clears.

Validation expected:

  • Current green CI is sufficient.

@dosubot dosubot Bot added the lgtm label Jun 5, 2026
@JSONbored
JSONbored merged commit 6036ce6 into JSONbored:main Jun 5, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 5, 2026
@JSONbored JSONbored added gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. and removed gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

feat(settings): generate repo onboarding pack for accepted Gittensory repos

2 participants