feat(observability): add dashboard panel + alert for review-floor clamps - #3932
Conversation
gittensory_ai_review_onmerge_clamped_total was registered and incremented whenever a repo's config tried to loosen the operator's onMerge/combine/reviewer-count floor, but had no Grafana panel and no Prometheus alert -- a governance-relevant signal nobody would actually see. Its sibling gittensory_ai_review_inconclusive_total already gets both; this closes the asymmetry. Closes #3901
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review result - approve/merge recommendedReview updated: 2026-07-07 07:11:58 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 6 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3932 +/- ##
=======================================
Coverage 93.58% 93.58%
=======================================
Files 358 358
Lines 34342 34342
Branches 12570 12570
=======================================
Hits 32138 32138
Misses 1580 1580
Partials 624 624 🚀 New features to boost your workflow:
|
Summary
gittensory_ai_review_onmerge_clamped_totalfires whenever a repo's.gittensory.ymltries to loosen the operator's onMerge/combine/reviewer-count floor and gets clamped back — per its own surrounding comment, this exists to ensure "a fired clamp increments a metric so it is surfaced, not silently ignored." The metric was registered and incremented correctly, but no Grafana panel queried it and no Prometheus alert referenced it — a counter nobody scrapes into a dashboard or alert is functionally silent for an operator not manually curling/metrics.gittensory_ai_review_inconclusive_total(a very similar shape) already has both a panel-equivalent story and a Prometheus alert, confirming this was a real asymmetric gap.statpanel tografana/dashboards/gittensory.jsonand a newGittensoryAiReviewOnMergeFloorBypassAttemptedalert toprometheus/rules/alerts.yml, mirroring the exact> 0/for: 5m/severity: warningshape already used byGittensoryAiProviderCircuitOpenfor the same "any occurrence over a window" alert style.Found via a fresh performance/scalability/accuracy hardening audit of the self-host ORB stack. Tracked under #1667.
Scope
grafana/dashboards/gittensory.json— new panel (appended at the end, its own gridPos row — no existing panel repositioned)prometheus/rules/alerts.yml— new alert ruletest/unit/selfhost-grafana-dashboard.test.ts— cover bothValidation
npm run typechecknpm run selfhost:validate-observability(dashboards + alert rules valid)npx vitest run test/unit/selfhost-grafana-dashboard.test.ts— 11/11 passinggit diff --checkcleanSafety
src/**lines, no secrets. New panel placed below every existing panel (its own gridPos) so no other panel was repositioned.Closes #3901