feat(engine): extract focus-manifest parse/compile core (#2280)

[jimcody1995]

Summary

• Moves the focus-manifest parse/compile core (parseFocusManifest, parseFocusManifestContent, gate/features/settings/review parsers, matchesManifestPath, compileFocusManifestPolicy, isFocusManifestPublicSafe, and related types/serializers) into packages/gittensory-engine/src/focus-manifest.ts as the canonical implementation for maintainer and miner parity.
• Keeps app-local resolver/guidance functions (buildFocusManifestGuidance, deriveContributionLanes, resolveEffectiveSettings, resolveReview*, etc.) in src/signals/focus-manifest.ts as a shim that re-exports the engine surface.
• Ports the settings/review normalizers the parser depends on into the engine package and adds barrel + branch-coverage tests so codecov patch coverage reaches 100% on the new module.

Closes #2280.

Test plan

• npx vitest run test/unit/focus-manifest.test.ts (513 tests, unmodified imports)
• npx vitest run test/unit/focus-manifest-engine-barrel.test.ts
• npx vitest run test/unit/focus-manifest-engine-branch-coverage.test.ts
• npm run typecheck
• Engine focus-manifest.ts branch coverage: 1302/1302 (100%) with focus-manifest test suite
• CI codecov/patch gate on PR diff

Made with Cursor

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review result - approve/merge recommended

_{Review updated: 2026-07-07 06:56:55 UTC}

32 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR ports the focus-manifest parse/compile core (parseFocusManifest, gate/settings/review parsers, compileFocusManifestPolicy, etc.) into packages/gittensory-engine/src/focus-manifest.ts, leaving src/signals/focus-manifest.ts as a re-export shim, and additionally ports the settings/review normalizer modules the parser depends on (command-authorization, screenshot-table-gate, moderation-rules, pr-type-label, contributor-blacklist, autonomy, linked-issue-*, safe-url) plus a hand-mirrored manifest-deps-types.ts. The visible code is a careful, convention-consistent port (normalize-with-warnings shape, defensive v8-ignore comments matching existing patterns) rather than new logic, and the description's justification for pulling in the dependency modules is coherent since the parser needs them. The main red flag is that codecov/patch failed hard (47.98% vs 99% target) despite the PR claiming 100% branch coverage on focus-manifest.ts itself, meaning the large surface of newly-ported dependency modules is materially under-tested for a diff this size; the manifest-deps-types.ts file is also a hand-maintained mirror of src/types.ts with no sync check in this diff, a documented but real drift risk.

Nits — 5 non-blocking

• codecov/patch is failing at 47.98% (target 99%) despite the claimed 100% branch coverage on focus-manifest.ts — the newly-ported dependency modules (command-authorization.ts, moderation-rules.ts, pr-type-label.ts, screenshot-table-gate.ts, etc.) appear to be the source of the gap and need their own coverage before merge.
• manifest-deps-types.ts:1-3 documents that it must be kept in sync with src/types.ts's RepositorySettings by hand with no automated check in this diff — worth adding at least a shape-equality test so the two definitions can't silently drift.
• Several newly added functions exceed the repo's nesting-depth convention (screenshot-table-gate.ts:63, command-authorization.ts:57, pr-type-label.ts:95, linked-issue-hard-rules-config.ts:69, contributor-blacklist.ts:44, auto-close-exempt.ts:39) — consider flattening with early returns.
• manifest-deps-types.ts is a 484-line single file (over the repo's ~400-line guideline) — could be split by settings domain (gate/settings/moderation) for readability.
• The PR bundles many settings/review modules alongside the core focus-manifest extraction (autonomy, contributor-blacklist, moderation-rules, command-authorization, pr-type-label, screenshot-table-gate, linked-issue-*, safe-url) — confirm each is a strict parse-time dependency of focus-manifest.ts rather than incidental scope creep, since that affects how reviewable this 32-file diff really is.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#2280
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 149 registered-repo PR(s), 95 merged, 0 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	jimcody1995; Gittensor profile; 149 PR(s), 0 issue(s).
Gate result	✅ Passing	No configured blocker found.

Review context

• Author: jimcody1995
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 149 PR(s), 0 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.66%. Comparing base (685a39e) to head (43dd5c8).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3891      +/-   ##
==========================================
+ Coverage   93.58%   93.66%   +0.08%     
==========================================
  Files         358      371      +13     
  Lines       34342    34834     +492     
  Branches    12570    12737     +167     
==========================================
+ Hits        32138    32627     +489     
- Misses       1580     1588       +8     
+ Partials      624      619       -5     

Files with missing lines	Coverage Δ
packages/gittensory-engine/src/focus-manifest.ts	100.00% <ø> (ø)
...ory-engine/src/review/enrichment-analyzer-names.ts	100.00% <100.00%> (ø)
...ngine/src/review/linked-issue-hard-rules-config.ts	100.00% <100.00%> (ø)
...ngine/src/review/linked-issue-label-propagation.ts	100.00% <100.00%> (ø)
packages/gittensory-engine/src/review/safe-url.ts	100.00% <100.00%> (ø)
...tensory-engine/src/review/screenshot-table-gate.ts	100.00% <100.00%> (ø)
...gine/src/review/unlinked-issue-guardrail-config.ts	100.00% <100.00%> (ø)
...ittensory-engine/src/settings/auto-close-exempt.ts	100.00% <100.00%> (ø)
...ackages/gittensory-engine/src/settings/autonomy.ts	100.00% <100.00%> (ø)
...nsory-engine/src/settings/command-authorization.ts	100.00% <100.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Gittensory approves — the gate is satisfied and CI is green.