feat(miner-foundation): move buildPredictedGateVerdict into gittensory-engine (#2283)

[jimcody1995]

Summary

• Extract buildPredictedGateVerdict and its signal/advisory dependencies into packages/gittensory-engine/ so miners can model gate verdicts with the same deterministic engine as the maintainer pipeline (feat(miner-foundation): move buildPredictedGateVerdict into gittensory-engine and re-point src/ #2283).
• Replace src/rules/predicted-gate.ts with a thin re-export shim; add engine parity, collision parity, and branch-targeted coverage tests aimed at 100% codecov patch coverage on the extraction diff.
• Rebased onto latest main (includes feat(miner-foundation): extract predicted-gate types into gittensory-engine #2276 predicted-gate types and feat(miner-foundation): extract scoring preview/model modules into gittensory-engine #2282 scoring exports); barrel exports preserve predictedGateNote / publicSafeFinding while adding buildPredictedGateVerdict.

Test plan

• npm run typecheck
• Predicted-gate unit/contract suites (predicted-gate.test.ts, engine-parity.test.ts, predicted-gate-engine-coverage.test.ts, predicted-gate-engine-branch-coverage.test.ts, predicted-gate-engine-collision-parity.test.ts)
• CI green including codecov/patch ≥ 99%

Closes #2283

Made with Cursor

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.57%. Comparing base (ac8414c) to head (c8346c5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3882      +/-   ##
==========================================
- Coverage   93.57%   93.57%   -0.01%     
==========================================
  Files         340      357      +17     
  Lines       33516    34309     +793     
  Branches    12262    12557     +295     
==========================================
+ Hits        31364    32105     +741     
- Misses       1528     1580      +52     
  Partials      624      624              

Files with missing lines	Coverage Δ
...es/gittensory-engine/src/advisory/gate-advisory.ts	100.00% <100.00%> (ø)
...s/gittensory-engine/src/focus-manifest/guidance.ts	100.00% <100.00%> (ø)
packages/gittensory-engine/src/github/constants.ts	100.00% <100.00%> (ø)
...nsory-engine/src/github/sanitize-public-comment.ts	100.00% <100.00%> (ø)
packages/gittensory-engine/src/predicted-gate.ts	100.00% <100.00%> (ø)
...ckages/gittensory-engine/src/review/check-names.ts	100.00% <100.00%> (ø)
packages/gittensory-engine/src/review/cla-check.ts	100.00% <100.00%> (ø)
...gittensory-engine/src/review/diff-file-priority.ts	100.00% <100.00%> (ø)
...s/gittensory-engine/src/review/guardrail-config.ts	100.00% <100.00%> (ø)
...s/gittensory-engine/src/review/pre-merge-checks.ts	100.00% <100.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-07 05:10:38 UTC}

28 files · 1 AI reviewer · no blockers · readiness 96/100 · CI pending · blocked

⏸️ Suggested Action - Manual Review

• Touches a guarded path — held for manual review: This PR changes guardrail-protected path(s): package.json (matched package.json), package.json (matched **/package.json).

Review summary
This PR mechanically extracts buildPredictedGateVerdict and its signal/advisory dependencies (predicted-gate-engine.ts, gate-advisory.ts) into packages/gittensory-engine/, leaving src/rules/predicted-gate.ts as a re-export shim, and closes the linked issue #2283 as required. The extracted code is heavily annotated with defensive `/* v8 ignore */` justifications and historical bug-fix commentary, suggesting genuine behavior-preserving extraction rather than new logic, and dedicated parity/collision/branch-coverage test suites were added to validate the move. codecov/patch is failing at ~98.36% against a 99% target, which is a coverage gap worth closing but is CI status, not a diff-visible correctness defect.

Nits — 6 non-blocking

• packages/gittensory-engine/src/advisory/gate-advisory.ts (mergeReadinessGateMode doc comment) uses 'Master merge-readiness composite' — swap to 'primary' or 'top-level' per the non-inclusive-terminology convention.
• predicted-gate-engine.ts mixes named threshold constants (MAX_COLLISION_PAIRWISE_ISSUES, etc.) with many inline magic numbers (0.58/0.75 term-overlap thresholds, 7/14/30-day windows, 6/8/10/20 burden-score weights) — consider naming the overlap/day/weight thresholds for consistency with the constants already extracted.
• predicted-gate-engine.ts and gate-advisory.ts are both large single files (985 and 643 lines) bundling several distinct concerns (collision detection, queue health, preflight, readiness scoring / advisory findings, gate evaluation) — consider splitting along those seams for future maintainability, though this is expected size for a straight extraction.
• The reported ReDoS-prone pattern in packages/gittensory-engine/src/github/sanitize-public-comment.ts:19 could not be verified since that file's diff is omitted from the provided content — worth confirming whether the flagged nested-quantifier pattern is new in this diff or pre-existing carried-over code.
• The many `/* v8 ignore */` annotations marking branches as 'defensive only'/'cannot occur' are individually justified with reasoning in-line, but given the coverage-rigor bar for this repo, it's worth periodically auditing that these truly are unreachable rather than under-tested real paths.
• Touches a guarded path — held for manual review — A maintainer must review and merge this change.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#2283
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (draft PR; 1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 146 registered-repo PR(s), 94 merged, 0 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	jimcody1995; Gittensor profile; 146 PR(s), 0 issue(s).
Gate result	⚠️ Not blocking	Advisory; not blocking this PR.

Review context

• Author: jimcody1995
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 146 PR(s), 0 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Mark ready when done.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review