Skip to content

feat(review): add review.auto_merge_summary read-only conditions table (#2051) - #3793

Closed
Lang-bt wants to merge 1 commit into
JSONbored:mainfrom
Lang-bt:feat/review-auto-merge-summary-2051-lang-bt
Closed

feat(review): add review.auto_merge_summary read-only conditions table (#2051)#3793
Lang-bt wants to merge 1 commit into
JSONbored:mainfrom
Lang-bt:feat/review-auto-merge-summary-2051-lang-bt

Conversation

@Lang-bt

@Lang-bt Lang-bt commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Closes #2051

Summary

  • Add review.auto_merge_summary (bool, default off) to the focus manifest — when enabled, the unified review comment renders a read-only Auto-merge conditions collapsible.
  • The table shows pass/fail for CI green, gate passing, mergeable-clean, and linked-issue signals derived from readiness facts the comment path already computed; it does not change merge/close decisions.
  • Document the knob in .gittensory.yml.example and config/examples/gittensory.full.yml (kept in sync).

Scope

  • The PR title follows type(scope): short summary Conventional Commit format.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • Linked open issue feat(config): add review.auto_merge_summary read-only knobs surface #2051 (help wanted, gittensor:feature).

Validation

  • git diff --check
  • npm run typecheck
  • npm run test:coverage -- test/unit/auto-merge-summary-collapsible.test.ts test/unit/focus-manifest.test.ts test/unit/unified-comment-bridge.test.ts test/unit/config-templates.test.ts test/unit/queue.test.ts -t "auto_merge_summary|auto-merge|Auto-merge|parses review.auto_merge" (targeted regression + queue wiring)
  • npm audit --audit-level=moderate (0 vulnerabilities)

Skipped (not touched by this diff):

  • npm run actionlint, npm run test:workers, npm run build:mcp, npm run test:mcp-pack, UI toolchain — no workflow/MCP/UI paths changed.

codecov/patch applies to changed src/** lines/branches (≥99% target). Added unit tests for derive/build helpers, manifest parse/serialize/resolve, bridge on/off render arms, and a queue integration test for processor wiring.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Display-only read-only table; gate/merge disposition code paths are not invoked from the new renderer.
  • New behavior has unit/integration tests for on/off arms, invalid manifest values, and processor wiring.

UI Evidence

N/A — backend unified-comment rendering only; no visible UI changes.

Notes

YAML template paths are covered by config-templates.test.ts. Default off ⇒ byte-identical comment when the knob is unset.

Made with Cursor

JSONbored#2051)

Wire the manifest knob through focus-manifest parse/serialize, the unified-comment
bridge collapsible, and the processor publish path with unit + queue integration tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Lang-bt
Lang-bt requested a review from JSONbored as a code owner July 6, 2026 10:39
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.33%. Comparing base (b5cd9db) to head (9636fad).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/review/unified-comment-bridge.ts 90.90% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (94.11%) is below the target coverage (99.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3793      +/-   ##
==========================================
- Coverage   93.33%   93.33%   -0.01%     
==========================================
  Files         317      317              
  Lines       32467    32481      +14     
  Branches    11901    11906       +5     
==========================================
+ Hits        30303    30316      +13     
  Misses       1530     1530              
- Partials      634      635       +1     
Files with missing lines Coverage Δ
src/queue/processors.ts 94.40% <100.00%> (+<0.01%) ⬆️
src/signals/focus-manifest.ts 99.11% <100.00%> (+<0.01%) ⬆️
src/review/unified-comment-bridge.ts 98.91% <90.90%> (-0.51%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 6, 2026
@loopover-orb

loopover-orb Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - fixes required

Review updated: 2026-07-06 11:31:05 UTC

9 files · 1 AI reviewer · no blockers · readiness 100/100 · CI failing · dirty

🛑 Suggested Action - Fix Blockers

Review summary
This adds `review.auto_merge_summary`, a display-only config toggle that renders a read-only pass/fail table (CI green, gate passing, mergeable-clean, linked-issue) in the unified review comment, derived from readiness facts the comment path already computes. The implementation follows the established `effortScore`/`changedFilesSummary` pattern exactly: manifest field + parser + serializer + `resolveReviewPromptOverrides` plumbing + processor wiring + bridge collapsible insertion, with default-off/byte-identical-when-absent behavior preserved across all the `EMPTY_MANIFEST`/`emptyManifest`/`parseReviewConfig` empty-object literals. The collapsible-chaining fix (using `withAutoMergeSummary` instead of `withFindingCategories` as the base for `withVisual`) is correct and necessary to avoid dropping the new section when a visual preview is also present.

Nits — 5 non-blocking
  • Patch coverage (94.11% vs 99% target) suggests the processor-level OFF path isn't exercised end-to-end — `queue.test.ts` only adds an integration test for `auto_merge_summary: true`; consider a companion test asserting `autoMergeSummaryEnabledForReview` stays false and the section is omitted when the manifest doesn't opt in.
  • The `feat(config): add review.auto_merge_summary read-only knobs surface #2051` issue-number literal is used as an inline comment marker in several new blocks (src/review/unified-comment-bridge.ts:487, src/signals/focus-manifest.ts:348) — consistent with existing codebase convention for other flags (e.g. Deterministic review-effort / complexity score + review-time ROI signal #1955, Finding category taxonomy on AI review findings #1958), so not worth changing, but flagged per the external brief for completeness.
  • `deriveAutoMergeSummaryInput`'s `linkedRow.cells[1].startsWith("✅")` assumes `cells` has at least 2 entries; worth a quick confirmation that `PublicPrPanelSignalRow.cells` is a fixed-length tuple elsewhere in the codebase (typecheck already passed, so likely fine).
  • Add the processor-level OFF-path integration test noted above to close the coverage gap before merge.
  • Consider factoring the four-row `AutoMergeSummaryInput` boolean derivation into named constants if a fifth condition is added later, to keep `deriveAutoMergeSummaryInput` readable — not needed at the current size.

CI checks failing

  • codecov/patch — 94.11% of diff hit (target 99.00%)
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2051
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 0 registered-repo PR(s), 0 merged, 0 issue(s).
Contributor context ❌ No public Gittensor match Lang-bt; not a blocker.
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: Lang-bt
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: JavaScript, Python
  • Contributor context: Public profile only; not a blocker.
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb

loopover-orb Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Gittensory is closing this pull request on the maintainer's behalf (CI is failing (codecov/patch); conflicts with the base branch — resolve and open a fresh PR). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(config): add review.auto_merge_summary read-only knobs surface

2 participants