fix(miner): allow nested lib/ paths in miner package checker - #3773
Closed
james3773 wants to merge 0 commit into
Closed
fix(miner): allow nested lib/ paths in miner package checker#3773james3773 wants to merge 0 commit into
james3773 wants to merge 0 commit into
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3773 +/- ##
=======================================
Coverage ? 93.29%
=======================================
Files ? 317
Lines ? 32368
Branches ? 11872
=======================================
Hits ? 30199
Misses ? 1537
Partials ? 632 🚀 New features to boost your workflow:
|
james3773
force-pushed
the
fix/miner-pack-nested-lib-2332
branch
from
July 6, 2026 09:10
456cf6c to
ede8961
Compare
12 tasks
kiannidev
added a commit
to kiannidev/gittensory
that referenced
this pull request
Jul 6, 2026
Resolve check-miner-package conflicts by taking upstream (JSONbored#3773) calibration layout. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
railway-app
Bot
temporarily deployed
to
enrichment-gittensory / production
July 9, 2026 03:13
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2332
Summary
scripts/check-miner-package.mjsallowlist regexes to accept nestedlib/<subdir>/*.jsartifacts (e.g.lib/calibration/index.jsfrom the chore(miner-selfimprove): scaffold packages/gittensory-miner calibration module directory + shared types #2332 calibration scaffold).npm pack --dry-runincludes the new subtree but the checker rejects it, breakingtest/unit/check-miner-package.test.tsand CIvalidate-code.Test plan
git diff --checknode scripts/check-miner-package.mjsnpm run test:coverage -- test/unit/check-miner-package.test.tsMade with Cursor