Skip to content

fix(signals): classify PHP gRPC service stubs as generated #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 6, 2026
Merged

fix(signals): classify PHP gRPC service stubs as generated #3754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/signals/path-matchers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,11 @@ function isGeneratedFileFrom(parts: NormalizedPath): boolean {
/_pb2(_grpc)?\.pyi?$/.test(norm) ||
// Ruby protobuf: message stubs are `*_pb.rb`; the gRPC plugin emits sibling `*_services_pb.rb`.
/_pb\.rb$/.test(norm) ||
// PHP protobuf: message stubs are `*_pb.php`; the gRPC plugin emits sibling `*_grpc_pb.php`.
// PHP protobuf: message stubs are `*_pb.php`; the gRPC plugin emits sibling `*_grpc_pb.php`
// and grpc-php service stubs (`*Grpc.php`, `*GrpcStub.php`).
/_pb\.php$/.test(norm) ||
/grpc\.php$/.test(norm) ||
/grpcstub\.php$/i.test(norm) ||
// Nim protobuf: message stubs are `*_pb.nim`.
/_pb\.nim$/.test(norm) ||
// Lua protobuf: message stubs are `*_pb.lua`.
Expand Down
6 changes: 6 additions & 0 deletions test/unit/path-matchers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ describe("isGeneratedFile", () => {
"gen/service_services_pb.rb",
"gen/service_pb.php",
"gen/service_grpc_pb.php",
"gen/GreeterGrpc.php",
"gen/FooGrpcStub.php",
"proto/messages.pb.rs",
"lib/my_proto.pb.ex",
"proto/service.grpc.swift",
Expand All @@ -110,6 +112,8 @@ describe("isGeneratedFile", () => {
expect(isGeneratedFile(path)).toBe(false);
}
expect(classifyChangedFile("gen/service_grpc_pb.php")).toBe("generated");
expect(classifyChangedFile("gen/GreeterGrpc.php")).toBe("generated");
expect(classifyChangedFile("gen/FooGrpcStub.php")).toBe("generated");
expect(classifyChangedFile("lib/my_proto.pb.ex")).toBe("generated");
expect(classifyChangedFile("proto/service.grpc.swift")).toBe("generated");
});
Expand Down Expand Up @@ -526,6 +530,8 @@ describe("classifyChangedFile", () => {
["dist/app.min.js", "minified"],
["src/api.generated.ts", "generated"],
["gen/service_grpc_pb.php", "generated"],
["gen/GreeterGrpc.php", "generated"],
["gen/FooGrpcStub.php", "generated"],
["lib/my_proto.pb.ex", "generated"],
["proto/service.grpc.swift", "generated"],
["proto/messages.pb.erl", "generated"],
Expand Down
Loading