Skip to content

test(review): lock in changed-files summary collapsible render (#2145) - #3748

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
luciferlive112116:test/changed-files-render-2145
Jul 6, 2026
Merged

test(review): lock in changed-files summary collapsible render (#2145)#3748
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
luciferlive112116:test/changed-files-render-2145

Conversation

@luciferlive112116

Copy link
Copy Markdown
Contributor

Closes #2145

Summary

Validation

  • npm run typecheck
  • npx vitest run test/unit/changed-files-summary-collapsible.test.ts

UI Evidence

N/A — test-only.

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.30%. Comparing base (c707394) to head (53fd9c8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3748   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         317      317           
  Lines       32363    32363           
  Branches    11873    11873           
=======================================
  Hits        30195    30195           
  Misses       1537     1537           
  Partials      631      631           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 6, 2026
@loopover-orb

loopover-orb Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-06 07:30:56 UTC

1 file · 1 AI reviewer · no blockers · readiness 62/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This is a small, test-only PR that closes issue #2145 by locking in the changed-files summary's collapsible rendering: it retags two existing describe blocks with the issue number and adds one new assertion (`toMatch(/<details><summary><b>Changed files<\/b><\/summary>/)`) confirming the unified comment wraps the changed-files table in a `<details>` element via the existing `extraCollapsibles` wiring. The diff is minimal, coherent with its description, and CI passed on this exact commit, so the assertion is verified against real shipped behavior rather than a fabricated payload. No production code is touched — this purely adds regression coverage for already-shipped collapsible rendering.

Nits — 3 non-blocking
  • The regex `/<details><summary><b>Changed files<\/b><\/summary>/` is a fairly rigid string match on markup formatting (tag order/casing); consider a slightly looser assertion (e.g. checking `<details>` wraps the table content) so a harmless markup tweak (e.g. attribute addition) doesn't spuriously break this test.
  • Consider also asserting the corresponding closing `</details>` tag appears after the table content, to fully pin down the collapsible boundary rather than just the opening summary line.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2145
Related work ⚠️ 2 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 180 registered-repo PR(s), 94 merged, 18 issue(s).
Contributor context ✅ Confirmed Gittensor contributor luciferlive112116; Gittensor profile; 180 PR(s), 18 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: luciferlive112116
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: JavaScript, MDX, Python, Rust, TypeScript
  • Official Gittensor activity: 180 PR(s), 18 issue(s).
  • Related work: Titles/paths share 6 meaningful terms. (issue #2145, issue #2150)
  • Related work: Titles/paths share 8 meaningful terms. (issue #2145, issue #2157)
Contributor next steps
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 83456e1 into JSONbored:main Jul 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(review): render changed-files summary as a collapsible table in the unified comment

1 participant