fix(signals): classify C# and Dart gRPC service stubs as generated - #3735
Conversation
Recognize grpc-dotnet *Grpc.cs and Dart .pbgrpc.dart service stubs in isGeneratedFile so generated-only diffs classify correctly for slop signals and the changed-files summary classifier. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-06 06:53:22 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
Extend
isGeneratedFileto recognize grpc-dotnet service stubs (*Grpc.cs) and Dart gRPC service stubs (.pbgrpc.dart), matching the existing Java/Kotlin/Swift gRPC stub matchers. Accurate generated-file classification is a prerequisite for distinguishing generated-only diffs from hand-authored source when calibrating PR scope.Fixes #3005
Scope
CONTRIBUTING.md.Validation
git diff --checknpm run test:cion Node 22npm audit --audit-level=moderate— 0 vulnerabilitiesisGeneratedFile,classifyChangedFile, and the representative cases tableIf any required check was skipped, explain why:
Safety
UI Evidence
N/A — signals-only change with no visible UI.
Notes
Incremental path-matcher parity for #3005: grpc C#/Dart protobuf service stubs now classify as
generatedviaclassifyChangedFile, so slop signals and scope heuristics do not treat machine-generated gRPC output as substantive hand-authored source.Does not deliver the miner driver prompt calibration slice — only closes a generated-classification gap in the shared path-matcher module.
Conflict avoidance: Touches only
src/signals/path-matchers.tsandtest/unit/path-matchers.test.ts. Zero overlap with open PRs (#3724 local-branch scoring, #3718 finding severity floor, #3712 visual shot bounds, #3704 miner calibration types, #3702 miner README, #3698 ignored-author gate).Made with Cursor