fix(queue): force a fresh AI review on manual panel retrigger - #3729
Merged
Conversation
The PR-panel "Re-run Gittensory review" checkbox re-ran the deterministic gate pass but never set forceAiReview, so it silently reused whatever AI review was already cached or frozen for the current head SHA instead of spending a fresh opinion. Reproduced on #3702 (reviewerCount stuck at 0 across repeated retriggers). Closes #3725
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Contributor
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 Gittensory is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3729 +/- ##
=======================================
Coverage 93.38% 93.38%
=======================================
Files 317 317
Lines 32309 32309
Branches 11848 11848
=======================================
Hits 30171 30171
Misses 1507 1507
Partials 631 631
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maybeProcessPrPanelRetriggernever setforceAiReview: truewhen callingmaybePublishPrPublicSurface, even thoughforceAiReviewexists specifically for this manual-override case (it bypasses both the AI-review cache and the manual-review freeze) — the only other call site that ever sets it (reReviewStoredPullRequest) is gated behind aforceflag no production scheduler or webhook sets today.Code review: No blockers | No AI review summary(reviewerCount: 0), and repeatedly checking the rerun box did not change that.forceAiReview: trueto the optionsmaybeProcessPrPanelRetriggerpasses tomaybePublishPrPublicSurface, so a manual retrigger always spends a fresh AI review instead of replaying a stale one.Closes #3725
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateSafety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.No UI changes in this PR — backend queue-processor fix only, so the UI Evidence section below is not applicable.
Notes