Skip to content

fix(queue): force a fresh AI review on manual panel retrigger - #3729

Merged
loopover-orb[bot] merged 1 commit into
mainfrom
fix/panel-retrigger-force-ai-review
Jul 6, 2026
Merged

fix(queue): force a fresh AI review on manual panel retrigger#3729
loopover-orb[bot] merged 1 commit into
mainfrom
fix/panel-retrigger-force-ai-review

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • The PR-panel "Re-run Gittensory review" checkbox re-runs the deterministic gate/disposition pass but never actually asked the AI-review pipeline for a fresh opinion — it silently reused whatever review was already cached (or frozen for manual review) at the current head SHA. maybeProcessPrPanelRetrigger never set forceAiReview: true when calling maybePublishPrPublicSurface, even though forceAiReview exists specifically for this manual-override case (it bypasses both the AI-review cache and the manual-review freeze) — the only other call site that ever sets it (reReviewStoredPullRequest) is gated behind a force flag no production scheduler or webhook sets today.
  • Reproduced live on docs(miner): document append-only event ledger in README (#2322) #3702: the panel showed Code review: No blockers | No AI review summary (reviewerCount: 0), and repeatedly checking the rerun box did not change that.
  • Fix: add forceAiReview: true to the options maybeProcessPrPanelRetrigger passes to maybePublishPrPublicSurface, so a manual retrigger always spends a fresh AI review instead of replaying a stale one.

Closes #3725

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

No UI changes in this PR — backend queue-processor fix only, so the UI Evidence section below is not applicable.

Notes

The PR-panel "Re-run Gittensory review" checkbox re-ran the deterministic
gate pass but never set forceAiReview, so it silently reused whatever AI
review was already cached or frozen for the current head SHA instead of
spending a fresh opinion. Reproduced on #3702 (reviewerCount stuck at 0
across repeated retriggers).

Closes #3725
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 6, 2026
@loopover-orb

loopover-orb Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Important

🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪

🔍 Gittensory is reviewing…

AI analysis is in progress. This comment will update when the review is complete.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.38%. Comparing base (3218df3) to head (6ab8553).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3729   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files         317      317           
  Lines       32309    32309           
  Branches    11848    11848           
=======================================
  Hits        30171    30171           
  Misses       1507     1507           
  Partials      631      631           
Files with missing lines Coverage Δ
src/queue/processors.ts 94.07% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 07dc5bf into main Jul 6, 2026
10 checks passed
@loopover-orb
loopover-orb Bot deleted the fix/panel-retrigger-force-ai-review branch July 6, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(queue): manual panel retrigger never forces a fresh AI review

1 participant